Decouple change records from www.drupal.org issues

Affected field is field_issues

Admin path:/admin/structure/types/manage/changenotice/fields

Certain views, like https://www.drupal.org/list-changes/drupal/review rely on the metadata of the issues. By making them links, we might not be able to retrieve the status anymore.

To continue working on this might mean losing certain functionality like ^^, but we can always create follow up issues to see what are the options (ie: query gitlab api to get MR or Issue metadata).

Also, if the issue is part of a change record, it'll have an extra block on the side making reference to the change record. ie: https://www.drupal.org/project/drupal/issues/3280399

My first thought is to use Gitlab issues for the change record itself. Any issue with the label 'Change record' would be considered a change record. Gitlab's issues dont yet allow for custom fields so that's why I suggest using a Label.

Gitlab's excellent query UI would help us make lists, even across projects. Further, issues have a rich UI and data for relating to each other and showing a bit of metadata in the link. We are surely going to be using these for Related Issues. Gitlab's Issue API is available for migration, and any future CRUD work related to change records.

This solution isnt perfect but its good enough IMO, and gets rid of one more custom thing on www.drupal.org

Thanks for your insights Moshe. Leveraging Gitlab is in fact one of the options being considered (probably the one we like the most long term). The changes in this issue will be about preparing for the issue migration without disrupting (too much) other parts of the site.

I've added a comment to the child issue about using gitlab features for the change records: https://www.drupal.org/project/drupalorg/issues/3293315#comment-14589560

BEFORE
select count(*) from field_data_field_issues; | 6310 |
select count(*) from field_data_field_issue_links; | 0 |

$ drush drupalorg_change_notice:issue-links
4397 nodes will be updated.
Starting...
* 198/4397 processed...
* 395/4397 processed...
...
* 4386/4397 processed...
* 4397/4397 processed...

AFTER
select count(*) from field_data_field_issues; | 6310 |
select count(*) from field_data_field_issue_links; | 6290 |

Discrepancy is just due to (probably just my DB):
    SELECT count(entity_id) FROM field_data_field_issues WHERE entity_id NOT IN (SELECT nid FROM node); | 20 |

@drumm - this is ready to be reviewed / tested.

URL: https://fjgarlin-drupal.dev.devdrupal.org

MR: https://git.drupalcode.org/project/drupalorg/-/merge_requests/101/diffs
* drupalorg/drupalorg.module changes the link to use the new format.
* features/drupalorg_change_notice/drupalorg_change_notice.drush.inc adds the drush command
* features/drupalorg_change_notice/drupalorg_change_notice.module adds the logic run in the drush command and a form_alter hook to pre-populate the links if these are given in the URL. It also adds some logic to keep backwards compatibility.
* The rest of the changes are features export from adding the new field and hiding the old one.

Deployment steps:
* Deploy the code and make sure that the feature changes were applied. A new field should be created. If it doesn't happen, we might need to "revert" the feature.
* Run the drush command: "drush drupalorg_change_notice:issue-links"

Changes:
* The old "Issues" entity reference field will no longer be available nor visible.
* A new field "Issue links" is available when viewing/editing/adding change records: https://fjgarlin-drupal.dev.devdrupal.org/node/3260624
* The link "add change notice" present in issues will still prepopulate the value of the link: https://fjgarlin-drupal.dev.devdrupal.org/i/3280589 and then click on "add change notice". You'll be taken here: https://fjgarlin-drupal.dev.devdrupal.org/node/add/changenotice?field_pr...

Once this is deployed, we can fully delete the old field and remove the non-used view displays, but that will break backwards compatibility. I captured this in the child issue: https://www.drupal.org/project/drupalorg/issues/3293585

The proposed resolution has been implemented and can be tested.

• Code changes: https://git.drupalcode.org/project/drupalorg/-/merge_requests/101
• Approach:
  • New link field was created and is multi-value. It requires absolute links.
  • Old entity reference link has been hidden and will no longer be used.
  • When combined with the work done on the gitlab migration issue, the links metadata is brought via JS.
  • When viewing an issue linked to a change record, the change record is still visible as the view has been changed to try to match the any of the values of the new link field to the current issue being viewed.
  • Change records can still be created from within a drupal issue and the issue will be prepopulated in the new format.
  • A drush command was created to populate the new field with the values from the old (hidden) field, for all previous change records.

Test:

• Change record listing: https://fjgarlin-drupal.dev.devdrupal.org/list-changes/config_notify/drafts (added field as POC, it can be removed if it’s not useful)
• Change record detail: https://fjgarlin-drupal.dev.devdrupal.org/node/3292914 Click on the link in the listing
• Issue mentioned in a change record: https://fjgarlin-drupal.dev.devdrupal.org/project/config_notify/issues/3... Click on the link in the change record detail page

Note: the above endpoint has been reset and I'll re-run all the changes early this week, so the test links might not show what you expect if you check between now and then.

Fixed