Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Today, I updated our organization page iO (https://www.drupal.org/node/2242363) with our current office locations located in Belgium, Netherlands and Sweden.
The offices in field on the organization page still shows the old values: Belgium and Netherlands. Sweden is missing.
Steps to reproduce
- Visit an organization edit page.
- Edit the Office locations field.
- the values shown under Offices in do not match the Office locations.
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork drupalorg-3249687
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
hestenetWe are not yet displaying the new values because we have wanted to provide transition time for organizations to update this information.
Per the email notification to organization profile owners - we intend to enforce the change on marketplace filtering on/after Jan 15 - but I suppose we could update what displays directly on the profiles sooner than that...
Comment #3
drummThe field has been disabled for awhile. We should audit the codebase to remove all references to
taxonomy_vocabulary_52, including deleting the field, ahead of upgrading Drupal.org past Drupal 7. #3249687: Organization page: Remove Offices in field has an example of this replacement for the community case studies filter.Comment #4
fjgarlin CreditAttribution: fjgarlin as a volunteer and at Drupal Association commentedFrom slack: https://drupal.slack.com/archives/C5ABFBZ5Z/p1679860381481319
@dasjo:
i have filtered for switzerland: https://www.drupal.org/case-studies/community?country%5B%5D=24422
it seems like most displayed case studies aren't related to switzerland
it might be that it filters by organizations serving a location, if so it might be more appropriate to only filter by organizations having an office in a certain location
e.g. https://www.drupal.org/case-study/schwaketenbad-website-relaunch is a case study by 1xinternet that has offices in germany, spain and iceland.
the issue where it was requested and implemented can be found here https://www.drupal.org/project/drupalorg/issues/3207977
reply @fjgarlin:
the feature has Locations served: https://git.drupalcode.org/project/drupalorg/-/blob/7.x-3.x/features/dru..., which actually explains why these results are showing up.
the change happened in this commit https://git.drupalcode.org/project/drupalorg/-/commit/36d4ce02e6a145c0ea... and seems to be a part of a larger issue where that old field is being deprecated: #3249687: Organization page: Remove Offices in field
so maybe it’s using the wrong field.
* Before: taxonomy_vocabulary_52
* Current: field_organization_loc_served
* Expected: field_office_location???
Comment #5
drummThe new address field on organizations, “Office locations” (
field_office_locations) does have a country-of-address filter, so that is an option for case studies, and anything else that needs replacing.Comment #7
fjgarlin CreditAttribution: fjgarlin as a volunteer and at Drupal Association commentedNote that the data on my copy is old so new case studies might not show, but I've done the changes on the field for that view. I've changed from "Locations served" to "Office locations".
You can see the page here: https://fjgarlin-drupal.dev.devdrupal.org/case-studies/community?country...
And the MR with the changes here: https://git.drupalcode.org/project/drupalorg/-/merge_requests/159/diffs
Comment #9
drummLooks good, going ahead and deploying this shortly. Resetting to active since there is more work to do in this issue.