Do not automatically credit people who upload files to an issue

look to me like the tick cannot be disabled

The maintainer can certainly untick credit when they update the issue. But yes, if it is the default, it will tend to stay ticked.

Changing this behavior is certainly straightforward, but I’d like to see a few more perspectives on it from project maintainers, since this is a large-enough change.

Here was my view on it: #3217991: Do not auto credit when uploading an image

Not following 100% what the code exactly does. Code wise the merge request looks okay, and I trust @drumm's judgment of what needs to be done to get this fixed ;-).

Yes, I think this was originally written to only suggest credit for patch files, so removing the line of code was straightforward, once it was found.

Just one more clarification- credit is never automatic. As a maintainer comments, its suggested for people who have uploaded files, but is not set until the maintainer updates the issue to confirm that.

Hmm is that true?

Cat image as example.

Okay seems you are right :-)

Possible bug introduced, see: https://www.drupal.org/project/drupal/issues/2617330#comment-14708000

Needs work in that case I guess?

I’m not seeing any real evidence of that. They didn’t have credit before, because that’s what the maintainer had saved. That could have been we we’re auto-suggesting credit for uploading patch files at the time, or maybe the pithy comment didn’t warrant credit. Regardless, the issue isn’t fixed, so credit isn’t finalized.

Query used to see the credit history:

MariaDB [drupal]> SELECT from_unixtime(nr.timestamp), group_concat(DISTINCT u.name ORDER BY u.name) FROM field_revision_field_issue_credit fdf_ic INNER JOIN comment c ON c.cid = fdf_ic.field_issue_credit_target_id INNER JOIN users u ON u.uid = c.uid INNER JOIN node_revision nr ON nr.vid = fdf_ic.revision_id WHERE fdf_ic.entity_id = 2617330 GROUP BY fdf_ic.revision_id;
+-----------------------------+-----------------------------------------------+
| from_unixtime(nr.timestamp) | group_concat(DISTINCT u.name ORDER BY u.name) |
+-----------------------------+-----------------------------------------------+
| 2022-09-08 07:58:59         | dagmar,mfb                                    |
| 2022-09-26 15:46:30         | dagmar,mfb                                    |
| 2022-09-26 17:34:44         | dagmar,mfb                                    |
| 2022-09-26 19:08:10         | dagmar,mfb                                    |
| 2022-09-26 20:10:27         | dagmar,mfb,Ratan Priya                        |
| 2022-09-26 20:26:13         | dagmar,mfb,Ratan Priya                        |
| 2022-09-27 09:26:59         | dagmar,fgm,mfb,Ratan Priya                    |
| 2022-09-27 09:27:49         | dagmar,fgm,mfb,Ratan Priya                    |
+-----------------------------+-----------------------------------------------+

Again, this is only about suggested credit. Nothing automatically adds or removes credit, it is up to the maintainers of each project to decide as they fix issues.

Adding related issue.