Remove issue credit suggestions

In https://git.drupalcode.org/project/drupalorg/-/blob/4cf30addbf6ec238fdea..., we’ll have to add logic for this.

However, with a new branch, we only get the new branch’s HEAD hash. We don’t have what it was branched from. We don’t know where the commits came from - for example, if there is some time between issue forking and pushing the new branch, upstream commits can/should be in the new branch’s history. The best I can think of offhand is check if the last commit author matches the person pushing.

I noticed this yesterday in one of my issues so removed the credit because the person didn’t do anything or even add a comment.

To be fair, I’m pretty sure I’ve accidentally clicked the button before that did this, so I know not everyone is trying to game the system with this :)

So true @Kristen Pol. Also, there will always be a first time you push the "Create issue fork" button, where you're not sure what will happen, what if I break something, etc. Some go ahead and do it, others will probably never, sadly ...

I was somewhat accustomed to the Gitlab/Drupal interaction and its many moving parts. But all the recent interaction updating the README.md and all the README.txt -> README.md issues made me much more comfortable, simply due to repeat interaction with the system, adding comments, resolving comments, editing MR's, etc.

Which just gave me a thought: Would it be possible to make a training project for users who are new to Drupal/Gitlab, where they can create issues, add merge requests, add comments in the MR, resolve them, etc.? It could be housed under https://www.drupal.org/project/drupalgitlab

If possible, automated testing should probably be disabled to save resources, as well as any crediting, indexing in https://www.drupal.org/project/issues/content, and so on.

I think it would be a great way of lowering the barrier to entry, which as we know is tall for Drupal itself, adding Gitlab makes it even taller.

@ressa Oooh. I like that idea! Playground :)

That's actually a clever idea!

I am glad you like the idea! I have created #3344829: Drupal+Gitlab playground for new users, feel free to expand on the Issue Summary, add comments, etc. Playground is a great suggestion, and I have used in the issue. Thanks @Kristen Pol :)

Not quite as elegant as Neil's solution, but considering the pressure the credit system is under right now, removing all auto credit checking might be net neutral as far as extra work for maintainers, and also disincentivizes the behavior of doing empty things just for credit.

The MR on #12 looks good to me. Waiting for confirmation from @drumm in case there are some other cases that need to be considered.

This was discussed a bit here: https://drupal.slack.com/archives/C0451JV7HRD/p1689090567790169. And for now completely removing auto crediting seems to be the direction we are looking to take.

Adding a little more to the summary.

Adding a bit more detail. To be clear, issue credit was never automatic. It was suggested as a default for maintainers, which can end up being like a default if the maintainer isn’t spending too much time on credit, or doesn’t feel like removing the suggested credit.

This is now deployed.

The only credit suggestion is crediting people with authorship of commits mentioning the issue on the canonical repository. That is mostly for the maintainers to not worry about self-crediting, reviewing and committing is work you should go ahead and credit yourself for.

Adding "If a user creates an issue, opens a merge request, uploads a [...]" in the Issue Summary, since that's not currently stated, but the reality. I saw that this was missing while updating Granting credit to issue contributors, and @fjgarlin clarified it for me a while ago.