When someone clicks the "new branch" link on a gitlab-powered issue, if they are not logged into drupalcode.org they are shown a 404 page, instead of a 403 page that would indicate the person needs to log in.

Issue fork drupalorg-3155441

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    About issue forks
    Support from Acquia helps fund testing for Drupal Acquia logo

    Comments

    DamienMcKenna created an issue. See original summary.

    drumm’s picture

    drumm
    he/him
    Location NY, US
    CreditAttribution: drumm at Drupal Association commented
    Parent issue: » #2488266: [META] Improve Git workflow on Drupal.org by implementing issue workspaces
    Related issues: +#3044233: Ensure that when a user is granted a role allowing SSO, that they are signed into gitlab

    Assuming there’s nothing completely off about the state of your cookies, and the account being set up correctly - we should be able to detect when you aren’t logged into git.drupalcode.org in one of the JS fetches. I believe we could then complete the SSO process in a hidden iframe, so you are always logged in shortly after viewing an issue page with a fork.

    mglaman’s picture

    mglaman
    Primary language English
    Location WI, USA
    CreditAttribution: mglaman at Centarro commented

    Honorable +1, I just ran into this and didn't notice I was logged out of GitLab!

    drumm’s picture

    drumm
    he/him
    Location NY, US
    CreditAttribution: drumm at Drupal Association commented
    Assigned: Unassigned » drumm

    • drumm committed 2ecceb5 on 7.x-3.x 
      Issue #3155441: Ensure you are logged into GitLab, if possible
    drumm’s picture

    drumm
    he/him
    Location NY, US
    CreditAttribution: drumm at Drupal Association commented
    Status: Active » Fixed

    Pages with issue forks now do a request to check if you are logged into GitLab. If you are not, an iframe to initiate sign-on is added. This works well in Firefox and Chrome.

    I discovered this isn’t working at all for Safari, including the existing places we do this, #3157062: GitLab SSO does not automatically log in on Safari.

    Status: Fixed » Closed (fixed)

    Automatically closed - issue fixed for 2 weeks with no activity.