[meta] people dont know how comment attribution works and are not keeping the data accurate

From personal experience: issue attribution is easily glossed over indeed. The first (too) simple idea I had is to put these things below the submit button:

Idea: show a modal upon pressing "Save". Either showing the entire comment attribution UI, or just confirming that the attribution is correct.

But … I think reality is we have too many things in our comment form.

Every person completely new to d.o/Drupal Core that I've mentored about issue status etc has been overwhelmed by the many, many options.

So, in that sense, one thing that would indirectly help is not showing the "Credit & committing" fieldset at all for users that can't modify it anyway. One less overwhelming thing to look at. That should instead be visualized in the issue sidebar, i.e. just like it shows the current status, it can also show the credit so far.

So, in that sense, one thing that would indirectly help is not showing the "Credit & committing" fieldset at all for users that can't modify it anyway.

There is simply no way that you can know that. See I work now for the customer 2bits.

I think I didn't express myself clearly. Let me try again.

I think part of the problem here is that the "post a comment" UI is very complex. Removing the "Credit & committing" fieldset for users that can't modify it would simplify it, and thus help indirectly. But I think the information in that fieldset should still always be visible: in the issue sidebar, not in the comment form. Because it's issue metadata. It's the only issue metadata that's visualized in the comment form instead of in the issue sidebar. That makes no sense.

Well, I mean technically it makes sense, you either can work on issues in your freetime or also get some time during worktime, so crediting even specific parts of an issue to an employer would work.

The intent of the separate "volunteer" checkbox was to make volunteerism a "first-class citizen" and not be drowned out by corporate sponsorship. I believe that's how it's stored on the backend, just not exposed in the UI that way.

I can think of issues where the following has happened:

- I opened the issue in my free time because I was profiling something
- then it affected an actual client (A) site so got paid to write a patch for it (i.e. they ran into the issue and I recognised it as one I already knew about)
- that client ran the patch, then another client (B) ran into the same issue again, and I updated the patch for them
- then I re-rolled a couple more times on my free time to get it committed.

Or sometimes the reverse happens and I find an issue via client work but then end up working on it as general core time - the menu race condition recently was like that.

So being able to take those cases into account would be good.

Right, that's definitely the intent of every comment having a discrete opportunity to adjust credit, for exactly those use cases. And then if you as an individual get credit for the issue, both of those customers + you as a volunteer would get credit.

Just trying that in here.

Interestingly you can attribute a single comment both as a volunteer and to an organisation.

So the issue with that is that only one attribution appears down the bottom, which I guess is one of the original points of this issue but definitely see the disconnect.

Also not sure why it's checkboxes as opposed to radios.

The idea there was that your patch can be a mix of both volunteer time and corporate-sponsored time.

So the issue with that is that only one attribution appears down the bottom, which I guess is one of the original points of this issue but definitely see the disconnect.

Yep, that's why I added People give up on accurate credits after a while, because contributing to the same issue as both volunteer and as an employee is merged in favor of employee. to the IS.

Right, you can see discussion about that at #2453271-48: Make "I'm a volunteer" an explicit choice in the credit UI and below. The rationale for not including volunteer in the Credit & Committing fieldset (from @drumm) was:

The Credit & Committing fieldset will visibly mix commenters who marked as volunteer with ones that are "missing". That was okay for organizations, because it is something being added. I could imagine this being concerning for volunteer. (Or I could be over-thinking it.)