Cannot uncheck people who submitted patches from the issue credit UI

some contribution credit issues have d.o profile improvements tag, and some have nothing and are easy to get lost (and not about profiles), so tagging to organize credit ones.

Inverse problem: #2474609: Not possible to credit people who didn't comment in an issue

Also bumping this issue to major, since we are starting to see some instances where this bug might be encouraging unhelpful contributions that actually derail issues.

Thanks for bumping this up.

I currently see a user who simply reposts an existing - older - patch with just a new name. So he's currently collecting credits without actually doing anything, but also confusing the issue queue.

@ifrik, please email me via my contact form with the username misusing the system with the old patch. I'll review and take action. We have not seen a lot of gaming of the system at this point, but we do want to keep it clean.

Not receiving credit is stored currently, but the default values don't know about this. It uses previously received credit or has posted a patch regardless. I’ll change the default to has posted a patch after the last time a maintainer commented.

I have this fixed in the dev branch. Planning to deploy later today.

This has been deployed.

Nice solution @drumm.

@webchick and @xjm, can you both test and let us know if this meets the need?