Expose recent issue credits data on user & organization profiles

I edited the language in the mockup to be a bit more concise and less formal.

The current version of this for users can be previewed at https://ci-drupal.redesign.devdrupal.org/u/tim.plunkett and https://ci-drupal.redesign.devdrupal.org/u/lks90

(dev sites will under-count because older issues are truncated.)

I wonder if "Contributed to fixing X..." is a better wording. 'Closing' might give an impression we are talking not only about fixed issues, but also things like 'closed(won't fix), issue triage stuff.

Replacing closing with Fixing sounds like a good improvement to me, done.

And this is set up for organization pages now, examples at https://ci-drupal.redesign.devdrupal.org/marketplace/acquia, https://ci-drupal.redesign.devdrupal.org/marketplace/md-systems, and https://ci-drupal.redesign.devdrupal.org/drupal-association

joshuami reviewed this and asked for the links to go to listings of the specific issues credited. The specific information will help with QA and tracking down any abuse, too. And we could use more-broad UX work on user profiles, that's a separate issue.

The basics are there, so setting this to needs review, I'll be adding those other pages.

The links now go to pages like https://ci-drupal.redesign.devdrupal.org/u/tim.plunkett/issue-credits/3060 and https://ci-drupal.redesign.devdrupal.org/node/1204416/issue-credits/3060 listing the full history of credited issues.

wait, isn't that a list of just the "recent" ones?
I think it should be if those are the links from the "recent" block.

If the link comes from
"Contributed to fixing 70 issues in the past 3 months
Drupal core 48 issues"

then the link should like to just those 48 issues.

That should probably have a title which says something about the time frame those are from.

And maybe then also a link to All for ever (which wont be all forever until we do #2042697: Add historical issue credits to Drupal.org user profile

I think the test "Page Manager" should link to https://www.drupal.org/project/page_manager and the text "1 issue" should link to the issue list. The reason why is that I expected "Page Manager" to take me to the module page just like the "Projects" below. I think it should be consistent.

+1 for Having project titles link to the project (and separately linking the 'x issues')

And while I do agree that starting with a 3-month window is appropriate, since we lack historical data, I think we should still show historical contributions, especially for organizations, at least as that data becomes available. (Maybe that's the idea, anyway?)

Perhaps in a year, the text could say "in the past year", instead of "in the past 3 months". Why? For example, some companies may blow their contrib budget on hosting a bigger Sprint once or twice a year or something; if we never show more than a 3-month window, it may not give as clear a picture of an organization's ongoing commitment to contribution.

That said, it's great to see something concrete coming from all the discussion of organizational attribution! :-)

I see the points raised. I think we could launch with the list being "all credits recorded" and it wouldn't hurt much, but the confusing that clicking on the project title in two contexts creates could be a bit of a blocker.

What if the project title was still a link to the project, but the "x issues" count next to the title was formatted as a label that linked to the view that was a list of the issue credits? This could even match the appearance of the current "credit" labels on comments to reuse a pattern.

Here is a very quick mockup of what the format could look like—realizing that the grey is too dark and it looks a bit different than the credit labels on comments :)

Yep I think that looks good, or rather, I understand what I'm clicking on by looking at it.

Also, I think that it should show all data we have a history for as well, but I assumed that was the intention.

I restored the links to projects and separate link to the credited issues. I went with a bit lighter styling, just a comma to separate the two links.

wait, isn't that a list of just the "recent" ones?
I think it should be if those are the links from the "recent" block.

#2042697: Add historical issue credits to Drupal.org user profile should be combined into the work here, so we don't have another list of projects. Maybe something like "Drupal core, 48 recent issues, 142 total" in each line; or something more visual if we can do it.

There can be only one list of issues credited, so we don't have 2 pages that are quite similar. Since the page is a bit buried, I think it is okay to show all of what we have, even if it isn't a complete history. We could put a note on the page if needed.

I believe this is now ready to deploy. Any non-urgent followups can go to #2042697: Add historical issue credits to Drupal.org user profile.

This is now deployed.

Created a followup: #2514634: A user's profile should clearly show how they contribute

Created another followup: #2532074: Stop auto-creditting people if the issue is fixed

some contribution credit issues have d.o profile improvements tag, and some have nothing and are easy to get lost (and not about profiles), so tagging to organize credit ones.

#2491873: Add commits to user.json API endpoint is related to the historical issue, but I suspect we have a json problem in general with exposing credits. Shall we use that issue, or is there another?

The new credits are in the RestWS API, they are all fields, so they get exposed automatically. They are seriously lacking in documentation, the way they are stored is not obvious. Briefly, it is:

https://www.drupal.org/api-d7/node/2498497.json has field_issue_credit referencing comments by credited people.
https://www.drupal.org/api-d7/comment/9980901.json has field_attribute_as_volunteer. If that has a 0 value, then field_attribute_contribution_to and field_for_customer have relevant information.