Remove fileicons from file upload views

Yhea, and it awkwardly offsets all the titles. I would definitely love to see this fixed.

We should be able to leverage theme_file_icon() for this, right?

Currently, this is default theme_file_link() output ... is there a better theme function you'd like to see?

Lowering priority, due to the effort versus reward equation here ... currently, this is a default theme function, and forcing us to a custom theme function to remove it seems like unnecessary complexity.

This may be done in drupal.org customizations, instead of piling onto extended file field. (We generally want to keep PHP customizations in modules, not the theme.)

Am I mistaken, or isn't this configurable via the Field UI even?

I find that the file icons are a nice visual cue that tells you what the link is. Without that icon, you only know that the link is a file download from the 'File' header of the table, which is easily missed, and the file extension in the link itself, which requires you to scan the filename and break it down into pieces.

The type of the icon is also an easy way of spotting patches vs screenshots.

Looks like a good idea to remove them. Mostly clutter indeed and without them we get nicer alignments.
The number of buttons next to each item is a good indicator for wether something is a patch or not, here's a mockup:

Oops, new to dreditor, those buttons normally aren't there of course. Updated screenshot:

isn't this configurable via the Field UI even?

Not that I know of. theme_file_link() hard-codes calling theme('file_icon', …). We can override theme_file_icon() to return an empty string.

This is running at https://lax1-drupal.redesign.devdrupal.org/node/2469929

This is deployed now. File icons on comments will remain in places as caches, especially the comment render cache, clear.

nice. thanks.