Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
There are pages that only documentation team can edit.
This is the documentation page explaining some of the locked pages
http://drupal.org/node/319685
Proposed resolution
a small note at the bottom of pages that cannot be edited that link either
to the project where an issue can be created to suggest a change or edit
or
to a page like http://drupal.org/node/319685 explaining the process for changing a page
Dev site
Maybe use https://docs_manage-drupal.redesign.devdrupal.org/ to try it out.
Remaining tasks
User interface changes
API changes
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | core-revisions-tab-2012-08-23_0104.png | 58.47 KB | YesCT |
| #2 | locked-doc-2012-08-23_0108.png | 67.99 KB | YesCT |
Comments
Comment #1
YesCT CreditAttribution: YesCT commentedConcerns I have:
not all pages are simply locked documentation pages. Some are generated by a module. For example:
http://drupal.org/project/views/git-instructions
(#1741334: Amend git instructions for patching to point to the doc on making patches with git and #1744488: make Getting Involved Guide link more prominent part of my inspiration to file this issue)
perhaps it would generate too many requests to change pages
Maybe
the link can be to a generic version of http://drupal.org/node/319685 can be written, which explains in general that some pages are not editable, and to file an issue in the project (module) "responsible"
and
it should show just for logged in users (like the edit tab shows just for logged in users).
Comment #2
YesCT CreditAttribution: YesCT commentedSome screen shots of how that might look to a logged in user.
Comment #3
YesCT CreditAttribution: YesCT commentedCan the module (project) responsible for a page be detected automatically?
Comment #4
jhodgdonComment #5
bredlen CreditAttribution: bredlen commentedI see this has been pushed to the top. What, if anything needs to be done, and is that something I can help with?
Comment #6
jhodgdonIssues get "pushed to the top" when they are the most recent to be commented on -- it doesn't actually mean it's an urgent issue necessarily. :)
Comment #7
bredlen CreditAttribution: bredlen commentedOh, I understand that, but you changed it yesterday for a reason, and I assume that reason includes having something done about it.
Comment #8
jhodgdonNo, the reason was because it was in the wrong component.
Comment #9
jhodgdonUpdate: We still would like to do this. I think we should add the link to the sidebar.
It should be a small patch in the drupalorg project, in the drupalorg_handbook module.
There's already some code there in drupalorg_handbook_block_view() in the 'meta-sidebar' section. This code is putting in an Edit link if the person has permission to edit, and a Log in link if the person is not logged in. I think we should just add a 3rd possibility there:
If the person is logged in but cannot edit the page, add a note that says:
You do not have permission to edit this page. To unlock it, see https://www.drupal.org/documentation/unlock-page
(I just added an alias to the unlock explanation)
Comment #10
jhodgdonAnd regarding the questions above from YesCT, I think if the volume of requests gets too big we can explore adding more to the sidebar or more to the Unlocking explanation page. Also, individual pages that are locked can have explanations at the top as to why (and they probably should). I think many of the locked pages were locked in previous years past when not everyone had the ability to add images. But lets just do the simplest thing first.
Comment #11
batigolixAs mentioned in #9 can we add a note in the right sidebar that says:
"You do not have permission to edit this page. Learn how to unlock it"
Comment #12
batigolix@jennifer: I checked if I could provide a patch for this based on the code that I have in the dev server docs_manage-drupal.redesign.devdrupal.org. But I dont think I ever had a git repo or something similar for the drupal.org code.
So what do you think: can we provide a patch for this?
Comment #13
YesCT CreditAttribution: YesCT commentedhandbook page: develop on our server https://www.drupal.org/node/1018084 is my first guess at how to go about making a change for this.
Comment #14
jhodgdon#9 outlines where the patch needs to go. The first step would probably be to ping in the #drupal-infrastructure channel to have the docs_manage dev site rebuilt so it has updated code/content on it, or we can get rid of that one and make a new clean dev site (assuming the work on that one is all done, and I think it is).
Comment #15
YesCT CreditAttribution: YesCT commentedhttps://docs_manage-drupal.redesign.devdrupal.org/