Make issue revisions required

Hrm, patch appears to be a p0 patch, weird.

Anyway, this seems fine. However, it appears you still have to manually configure issue nodes to default to a new revision. Is that the intention? Should we just make the patch force that "Create a new revision" checkbox to default to TRUE while we're at it?

Presumably it defaults to TRUE for handbook nodes, and there's again code somewhere to clone over? The new revision needs to be required for general users, so I'd assume that it should default to checked for administrative users as well.

@xjm: Yes, the code to force this on handbook pages is somewhere is in core. ;) This is a UI setting at admin/content/node-type/[node-type] under "Workflow settings" (the "Default options:" checkboxes). Therefore, we have two choices:

A) Force this core setting to effectively be true via this form_alter in the drupalorg code. We just alter the node form (like we're already doing) to set #default_value on the "Create a new revision" checkbox to be TRUE (which is basically what core is doing).

The problem with this approach is that it makes the core setting meaningless, which could be confusing, since toggling the core setting won't actually effect issue nodes on d.o.

B) Toggle the admin UI setting when we're pushing #1036132: Provide a mechanism for issue summaries live.

The problems with this approach are that the rest of this patch (forcing the log message to be required, etc) doesn't make much sense if the core setting to require new revisions is disabled, and it's another thing we'd have to do manually while deploying #1036132...

I don't really care either way. We just have to pick an approach and stick with it.

I checked Create new revision under default options at http://drupal.org/admin/content/node-type/project-issue. And I committed the patch for the next deployment.

A) is a must, the problem is that the most passionate core developers tend to be node admins as well (/me looks in the mirror) and it's exactly those people who could engage in some deadly edit wars.

OK, discussed with webchick and -- while disagreement is OK don't try to mess with the summary abusing your rights or they will be removed.

For posterity: Drupal is good in this because reverting to an older revision actually copies so even on a revert nothing is lost if you keep that box checked.

Deployed.

On permissions and everything, this is separate from the larger issue; the debate doesn't really affect it. Can't really argue with revisions being required for issues being a good thing, whoever is editing for whatever purpose. That's why this sort of issue is good, it is straightforward & deployable.