Relevant change notice: https://www.drupal.org/node/2067859

drupal_set_title() was removed in D8. Diff calls it on its entity settings page, resulting in a fatal error.

This is quite a common function, so listing as major. However, it should be "Fun." :P

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented

Actually, is it possible with Pharborist to just comment out the entire damn line when a drupal_set_title() is involved? Reading the change notice, I literally don't see any way we could possibly auto-generate code for it. The resulting code completely depends on the context the function's being used in.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima commented

I have asked grom358 to implement the ability to comment out a line, and marked it as high priority. So for now, this awaits an upstream fix there.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Issue tags: +demo blocker

Sounds like this functionality's in Pharborist now, so tagging as an issue to focus on prior to demo.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima commented

As of commit a38af13, any line containing drupal_set_title() is unconditionally commented out. Still need to leave a FIXME notice, though.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented

Confirmed. :) Now it's whining about module_invoke_all() instead. :D

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Active » Closed (fixed)

This is now done + a fix me comment so calling this good enough for now. :)