In both http://cgit.drupalcode.org/drupalmoduleupgrader/tree/Drupal7to8/Sniffs/C... and http://cgit.drupalcode.org/drupalmoduleupgrader/tree/Drupal7to8/Sniffs/B... we need to write classes out into a "src/" directory, not lib/Drupal/modulename.

CommentFileSizeAuthor
#2 psr_0_ is_now_psr_4-2320243-2.patch4.72 KBundertext
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

undertext’s picture

undertext CreditAttribution: undertext commented
Assigned: Unassigned » undertext
undertext’s picture

undertext CreditAttribution: undertext commented
Status: Active » Needs review
FileSize
psr_0_ is_now_psr_4-2320243-2.patch4.72 KB

This patch removes all PSR-0 related code.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs review » Reviewed & tested by the community

Wow, great work! That's even more stuff than I remembered was in there about PSR-0. :D Tested it out and seems to work well; the block plugin is now in a /src/ directory vs. a /lib/Drupal/pants one.

The only thing I see off-hand, which is incredibly minor, is:

+++ b/Drupal7to8/Sniffs/Classes/PsrMoveSniff.php
@@ -42,19 +42,18 @@ class Drupal7to8_Sniffs_Classes_PsrMoveSniff implements PHP_CodeSniffer_Sniff {
+    if (!strstr($filename, '/src/' /* Future-proofing */)) {

We no longer need that "Future proofing" comment. (This can always be fixed on commit.)

I'd merge this in myself, but phenaproxima is in the middle of a big refactor atm and I don't want to make that any harder to merge in than necessary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima commented

Go ahead and merge it in. I haven't touched the PSR-0 stuff, so it should be OK. :)

  • webchick committed 3b3dc3d on master 
    Issue #2320243 by undertext: Fixed PSR-0 is now PSR-4.
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Roger that!

Committed and pushed to 8.x. :) Thanks a lot, undertext! If you're up for another, there's a second novice issue at #2320237: config/ directory should now be config/install.

  • webchick committed b04765d on master 
    Revert "Issue #2320243 by undertext: Fixed PSR-0 is now PSR-4."

Fixing...

m1r1k’s picture

m1r1k CreditAttribution: m1r1k commented
Issue tags: +#ams2014contest

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.