Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rocket.man created an issue. See original summary.

bkhandruk’s picture

Assigned: bkhandruk » Unassigned
Status: Active » Needs review
FileSize
4.57 KB

Replaced all deprecated uses in module.
Added dependencies injection for DrupalGapController.

tyler.frankenstein’s picture

Hi @rocket.man, thank you very much for the patch here. It looks clean and is much cleaner than my attempts before it. I'm sorry I should've made it more clear that the 8.x-2.x branch is deprecated at this time.

The 8.x-1.x branch is actually a backport of my prior attempts at an 8.x-2.x branch. The 8.x-1.x branch has since evolved and is used to power demo.drupalgap.org/8 and that branch had some things abstracted from it, and shipped over to jDrupal.

I applied your patch to the 8.x-2.x branch then compared the 2.x and 1.x branches side by side and the only major discrepency seems to be with the DrupalGapController.php file.

Most of the grunt work that was once done in the 8.x-2.x branch in the DrupalGapController.php file's drupalgapSystemConnect() function. That heavy lifting has been moved to the 8.x-1.x branch's implementation of hook_jdrupal_connect_alter() in the drupalgap.module file.

So 8.x-1.x's drupalgap_jdrupal_connect_alter() is used to do most of the magic for delivering the view/form modes to the app. I'd also actually like to move this magic to a sub module, e.g. drupalgap_entity_ui because learning from my mistakes in DrupalGap 7, I think it'd be best to offload this feature out of DrupalGap core.

You surely have superior Drupal 8 coding skills, and I hope you wouldn't mind back tracking a bit and using the 8.x-1.x branch instead. It'd be great for the module if we could get your coding standards and deprecation fixes applied to the 8.x-1.x branch and then evolve from there.

If this is of interest to you, I'll look to just delete the 8.x-2.x branch to avoid further confusion. Thank you again for taking the time to contribute to DrupalGap.

bkhandruk’s picture

Hi, @tyler.frankenstein.

Thank you for such a pleasant reply! I'll reroll the patch for 8.x-1.x branch as soon as I can.