Problem/Motivation

Currently the installer and recipes cannot be translated, see related issues. If you select a different language in the installer, Drupal core will install in the selected language, but most of the other config provided by Drupal CMS has EN language hardcoded.

So you will end up with mixed config in different languages, for example:
- anonymous, administrator roles will be in the default language, but the content_editor will be in EN language
- core menus will be in default language, but the Welcome menu will be in EN language
- etc..

I am not sure if this can cause any serious issues, when sites want to start translating things later, but still I do not see any significant benefit of having the languages in the installer, because even if you select a different language, installer will be still in EN language and as I wrote before, the site config will have mixed languages (default / EN).

I propose to remove the languages from the installer until the related / recipes translation issues are solved.

Steps to reproduce

Install Drupal CMS in a different language from EN. Examine the site config and see, that a lot of config provided by Drupal CMS is in EN language, even when the site has a different language (see the image).

Proposed resolution

Remove the languages from the installer for now.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
languages_roles.png18.58 KBpoker10

Issue fork drupal_cms-3497951

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

poker10 created an issue. See original summary.

poker10’s picture

pameeela’s picture

I'm fine with removing it, I think that is better if it results in a confusing experience.

poker10’s picture

Title: Consider removing languages from the installer » Remove languages from the installer
Status: Active » Needs review

Created an MR which removed the included JS and CSS files and hides the markup from the template. Not sure if we also want to remove the whole CSS and JS files from the repo, as there is a code which will be used in the future when multilanguage recipe will be added, but if yes, I think it can be done easily.

phenaproxima’s picture

Go ahead and remove them; we can always get them back from the Git history.

phenaproxima’s picture

Status: Needs review » Needs work
phenaproxima’s picture

You'll probably test at least one test failure, since the presence of the languages is exposed to drupalSettings: https://git.drupalcode.org/project/drupal_cms/-/blob/1.x/project_templat...

poker10’s picture

Status: Needs work » Needs review

Yeah, thanks! Find out that we need to remove also InstallerFormBase.php. Tests seems to be green now, so hopefully ready to review again.

phenaproxima’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me, thanks!

phenaproxima’s picture

Status: Reviewed & tested by the community » Fixed

Merged into 1.x and cherry-picked to 1.0.x. Thanks!

  • phenaproxima committed 17828840 on 1.0.x authored by poker10
    Issue #3497951 by poker10, pameeela: Remove languages from the installer
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.