Problem/Motivation
Currently the installer and recipes cannot be translated, see related issues. If you select a different language in the installer, Drupal core will install in the selected language, but most of the other config provided by Drupal CMS has EN language hardcoded.
So you will end up with mixed config in different languages, for example:
- anonymous, administrator roles will be in the default language, but the content_editor will be in EN language
- core menus will be in default language, but the Welcome menu will be in EN language
- etc..
I am not sure if this can cause any serious issues, when sites want to start translating things later, but still I do not see any significant benefit of having the languages in the installer, because even if you select a different language, installer will be still in EN language and as I wrote before, the site config will have mixed languages (default / EN).
I propose to remove the languages from the installer until the related / recipes translation issues are solved.
Steps to reproduce
Install Drupal CMS in a different language from EN. Examine the site config and see, that a lot of config provided by Drupal CMS is in EN language, even when the site has a different language (see the image).
Proposed resolution
Remove the languages from the installer for now.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| languages_roles.png | 18.58 KB | poker10 |
Issue fork drupal_cms-3497951
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
poker10 commentedSome related discussion from Slack: https://drupal.slack.com/archives/C072BF486FN/p1736266751121509
Comment #3
pameeela commentedI'm fine with removing it, I think that is better if it results in a confusing experience.
Comment #5
poker10 commentedCreated an MR which removed the included JS and CSS files and hides the markup from the template. Not sure if we also want to remove the whole CSS and JS files from the repo, as there is a code which will be used in the future when multilanguage recipe will be added, but if yes, I think it can be done easily.
Comment #6
phenaproximaGo ahead and remove them; we can always get them back from the Git history.
Comment #7
phenaproximaComment #8
phenaproximaYou'll probably test at least one test failure, since the presence of the languages is exposed to drupalSettings: https://git.drupalcode.org/project/drupal_cms/-/blob/1.x/project_templat...
Comment #9
poker10 commentedYeah, thanks! Find out that we need to remove also InstallerFormBase.php. Tests seems to be green now, so hopefully ready to review again.
Comment #10
phenaproximaLooks good to me, thanks!
Comment #12
phenaproximaMerged into 1.x and cherry-picked to 1.0.x. Thanks!