Problem/Motivation

The content model is very detailed (see https://docs.google.com/spreadsheets/d/1im8CByn4Lo9D6WjC-sj_m1uQojaUFmsk... to have a peek) and it's very easy to get minor details of the implementation wrong, because it's all just a big mountain of samey-looking YAML files.

In #3491296: Create person profile content type, I added some infrastructure to make it easy to test that the content model as implemented actually conforms to the spec. Let's expand that to all existing content types and shake out any bugs that reveals.

Issue fork drupal_cms-3491726

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

phenaproxima created an issue. See original summary.

phenaproxima opened merge request !272

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Reviewed & tested by the community

I am going to unilaterally commit this. Come at me, bro, if you must.

This keeps us honest, ensures our fidelity to the content model as designed and agreed to by the product owner and various stakeholders, and makes sure we don't screw up minor details during implementation and refactoring, which is very easy to do. It is well and good that it should evolve, but as it does, we need to maintain our adherence to what we've chosen.

I think it will only help us, not hurt us. If something in the content model changes, tests should break. That proves we are watching.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

+1 to RTBC.

  • phenaproxima committed 69814920 on 0.x 
    Issue #3491726 by phenaproxima: Add strong test coverage of the content...
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Fixed

Merged into 0.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.