Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
should be file_managed, not file
Comment | File | Size | Author |
---|---|---|---|
#9 | 970002.patch | 1.54 KB | EclipseGc |
#7 | 970002.patch | 762 bytes | EclipseGc |
#1 | 970002.patch | 396 bytes | EclipseGc |
Comments
Comment #1
EclipseGc CreditAttribution: EclipseGc commentedUsing git for this since it's kind to me than CVS, hopefully this patch is fine.
Comment #2
EclipseGc CreditAttribution: EclipseGc commentedComment #3
yched CreditAttribution: yched commentedTrue.
Comment #4
effulgentsia CreditAttribution: effulgentsia commentedNice catch. This looks correct, but columns.fid.description also needs to be updated. Looks like image_field_schema() and taxonomy_field_schema() also need a 'foreign keys' entry. I'll leave that up to you whether to roll those into this patch, or create separate issues for them.
Comment #5
EclipseGc CreditAttribution: EclipseGc commentedI already filed a separate issue for taxonomy.
#970016: taxonomy_field_schema lacks any foreign key support
Will look into image, and put together another patch for file to fix the description.
Comment #6
EclipseGc CreditAttribution: EclipseGc commentedsorry about that
Comment #7
EclipseGc CreditAttribution: EclipseGc commentedOK, hopefully this makes everyone happier.
Comment #8
mlncn CreditAttribution: mlncn commentedVery nice. Schema correctness++
Comment #9
EclipseGc CreditAttribution: EclipseGc commentedThis should probably include the image field foreign keys as well.
Comment #10
yched CreditAttribution: yched commentedThanks !
Comment #11
webchickChange to schema means we need an upgrade path, no?
Comment #12
webchickActually, in discussing this more with chx, an update function here is unnecessary. No core db engines, nor any of the ones we could find in contrib, actually put FK information into the database itself, so updating the PHP here should be sufficient.
Committed to HEAD.
Comment #13
Gábor HojtsyLooks like even though FK is not put into the database, descriptions are (at least with MySQL), so this needs an update function.