Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.small issue: http://api.drupal.org/api/group/schemaapi/6 would be *much* easier to read if the field options were a second level list, as at http://api.drupal.org/api/group/schemaapi/7
thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 948520-reroll.patch | 1.67 KB | jhodgdon |
| #4 | database.inc_.doxygen.patch | 1.56 KB | mvc |
Comments
Comment #1
jhodgdonYes, the formatting is wrong, thanks for reporting!
Fixing that would be a good project for a novice contributor.
There is information about list formatting on
http://drupal.org/node/1354#lists
Comment #2
mvcWhere is this text? How can I fix it?
Comment #3
jhodgdonThe text is inside a topic/group section in the file includes/database.inc
You can fix it by making a patch.
There's information about topic/group sections on drupal.org/node/1354 (see link above for list formatting bottom of that page has info about topic/group sections).
There's info on creating patches at http://drupal.org/patch/create
And you can get additional help on IRC -- see http://drupal.org/irc -- on the #drupal-contribute channel is the place to get help starting as a contributor. Is that enough to get you started?
Comment #4
mvcyes, thanks! i just didn't know which file to patch. i foolishly grep'd a fresh copy of drupal 6 without realizing that my search phrase would be broken across a newline, and when i saw no results i assumed this documentation was maintained outside drupal someplace. *blush*
i didn't actually install doxygen and the api module and properly test this patch, but i compared includes/database.inc against includes/database/schema.inc in drupal 7 (where the formatting works) and i believe this will fix the problem.
Comment #5
jhodgdonPlease read http://drupal.org/patch/create -- patches need to be rolled from the Drupal root, and should be done with cvs diff if possible. I could not get this patch to apply without editing the top.
Also, when you attach a patch, please set the status to "Needs review", so that we know there is a patch that is waiting for a review.
Apart from that, you did the exact right thing in that patch... so to save time, I just rerolled it. Thanks!
Comment #6
mvcthanks for your all your feedback, jhodgdon. i've submitted lots of patches for modules, but only a few for core, so i didn't think of rolling the patch from the drupal root directory. and yep, i definitely should have known to select "needs review"!
Comment #8
Gábor HojtsyCommitted, thanks.