Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In Chrome 6 on Mac I found the dashboad is not working as it should. When I drag items to and from the regions and back to the area of available blocks items loose this sizing.
I think a picture describes it best. http://img.skitch.com/20100922-mh1grw7wnmjux52jhggd43ip4h.png
I was not able to reproduce this in Safari.
Comment | File | Size | Author |
---|---|---|---|
#18 | 919290-18.patch | 4.18 KB | Jody Lynn |
#13 | 919290-13.patch | 4.16 KB | Jody Lynn |
#9 | dashboard.png | 20.13 KB | aspilicious |
#8 | 919290-6.patch | 2.55 KB | Jody Lynn |
#1 | 919290-ff.png | 76.3 KB | reglogge |
Comments
Comment #1
reglogge CreditAttribution: reglogge commentedI can reproduce this in Safari also. In Firefox it looks still different. Both are the Mac versions. Screens attached.
The reason seems to lie in the fact that menu blocks are automatically expanded upon placing them in a dashboard region, showing their menu entries. When putting them back in the tray, somehow this expanded state is retained which leads to these effects.
But is this critical? Since a simple page refresh solves this issue, I'm not sure that it qualifies. The functionality is still there, it just looks odd.
Comment #2
ksenzeeDefinitely not critical.
Comment #3
franzI had the same issue on Firefox 3.6.9 on Linux
Comment #4
franzActually, just open the customize interface and drag blocks around those disabled. This is enough to reproduce. It doesn't appear to be related to actually dragging the block to a region.
Comment #5
droplet CreditAttribution: droplet commenteddragged icon has contextual-links to configure it. does it by design ??
Comment #7
Jody LynnThe problem was that we were ending up with an extra nested block div due to the js using html() instead of replaceWith() to replace the newly loaded block. Also we should not have been using ajax to load the block when it was moving around in the disabled section and had not yet been enabled.
Another problem was that if you had a disabled block like 'Search' (which by default has no title) and you moved it into the enabled blocks, there would be no title, and you could end up with empty blocks in the disabled section.
Patch fixes both these problems.
Comment #8
Jody LynnComment #9
aspilicious CreditAttribution: aspilicious commentedSrry for this...
Waiting for this patch for a long time :)
Comment #10
Jody LynnI don't really understand what's happening in that screenshot, but I'll see if I can reproduce. Which block are you dragging there in English (or does it happen for every block)?
Comment #11
yoroy CreditAttribution: yoroy commentedThat's the recent comments block there.
Comment #12
aspilicious CreditAttribution: aspilicious commentedSrry for the dutch screenshot...
I talked with jody on irc, she is going to reroll.
Comment #13
Jody LynnOk, new patch fixes this and also avoids loading already fully-loaded blocks more than once.
Comment #14
aspilicious CreditAttribution: aspilicious commentedNot yet completly good :(
Thnx for your efforts btw.
I think it looks better if we delete the width part from the over event.
And put item.css('width', ''); on the start event. Than the width doesn't flikker all around.
Tested this myself, and I prefer it.
(and it would look nicer if we could copy the style from the disabled block, that way we always have the same style for dragged blocks)
Also, if you select a block (for example recent comments) close to the right upper corner of the block the border appears again o_O.
Afterwards it doesn't go away while dragging.
Comment #15
Jody LynnI'm not sure if those problems are related to this issue though.
The display of the block while dragging should be a separate issue (unless it's different with this patch applied). Can you confirm if any of these problems were introduced by this patch?
Comment #16
aspilicious CreditAttribution: aspilicious commentedI think this is introduced by this issue.
Not sure, no time for testing.
Comment #17
sunLike @ksenzee, I also don't think this is more severe than normal. Needs to go into D8 first.
Comment #18
Jody LynnI rerolled the patch.
I took a deeper look into it, and can confirm that the issues aspilicious mentions are unrelated to this patch. The issue described with the 'border when hovering over the top right' is due to contextual activating, which is the same before and after the patch (see #831088: Contextual links are showing for disabled dashboard blocks).
Comment #19
kscheirer#18: 919290-18.patch queued for re-testing.
Comment #21
droplet CreditAttribution: droplet commenteddoesn't it remove from D8 ?
Comment #22
marcingy CreditAttribution: marcingy commentedThis module no longer exists in d8