Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jensimmons’s picture

Status: Active » Postponed (maintainer needs more info)

I'm not sure what this issue is about. Can you explain more?

buwk’s picture

user login blocks is very long (in before.png). you did forget add

#block-user-login .form-text {
max-width: 156px;

to style.css .

And you forget

input.form-text,
textarea.form-textarea,
select.form-select {
border: 1px solid #ccc;
max-width: 414px;

add to style.css .

sorry bad English

jensimmons’s picture

Project: Bartik » Drupal core
Version: 7.x-1.0-rc3 » 7.x-dev
Component: Look and Feel » Bartik theme
Status: Postponed (maintainer needs more info) » Active

I think buwk is saying that some of the forms are too wide, and that breaks the layout. Can someone else reproduce such a bug?

jensimmons’s picture

I have to say, it's not the lack of English that's confusing, it's these screenshots! Oh my. LOL.

Before:
screenshot of Bartik with totally broken layout and crazy lines drawn all over everything

After:
an after screenshot, with things more normal

Jeff Burnz’s picture

Title: fixes for long forms » Fix long input form elements

The screenshots are not available at the moment due to the site being in maintenance - would be good if they can be added here - this is directly related to #881264: Username/password input fields overlap content (Firefox 3.6 on Ubuntu Linux) (which I marked as duplicate since this issue is older).

Heres the screenshot from that issue:

overflowing input elements in Firefox for Linux

I dont have a linux setup to test with right now, I could run one and test this but if someone else could apply a simple fix such as the following to confirm the issue and a plausible fix, or provide some detailed debug info as to why this happens:

#block-user-login .form-text {
  width:158px;
}
patrickfgoddard’s picture

Downloaded 7.x-dev and quickly check with Chrome on Firefox 3.6.8 and was NOT able to confirm this. Login input boxes displayed fine.

buwk: Can you please state what browsers and versions you were seeing this issue in?

Lenz Grimmer’s picture

Quoting from my original bug report: "This only happens when rendering the page with Firefox on Linux (3.6.8 as shipped with Ubuntu Lucid), the page looks fine in the Google Chromium browser."

buwk’s picture

I tested on firefox 3.6.8 and ie8(on win7(not only linux!)). not only login forms, register forms are broken...

Jeff Burnz’s picture

Sivaji_Ganesh_Jojodae’s picture

Attached is the home page screenshot from various browsers, OS Ubuntu 10.04, everything looks fine here. Is it fixed ?

Jeff Burnz’s picture

Nothing has changed with regards to form elements in Bartik recently afaik.

johanneshahn’s picture

jensimmons’s picture

Status: Active » Postponed (maintainer needs more info)

I'm setting this to needs more info. All the screenshots of bugs are broken. The original screenshots just open spam windows.

I don't know that we have a problem here.

bluegray’s picture

I can confirm the bug. Screenshot attached. This is with Firefox 4 RC1 on Ubuntu Linux.
It looks like a problem with the font rendering width in firefox, since Chrome is fine.

Using 'Lucida Grande' makes the text input box wider than it should, using any other font is fine.

To fix:
a) Change font from 'Lucida Grande' or
b) Set width on text input element with css.

Setting css width for input elements is probably a good idea, since the size attribute renders differently across browsers.

related issues: #833184: 60 col fields can overflow the main content column and #903450: Form elements too long for Opera

Jeff Burnz’s picture

Version: 7.x-dev » 8.x-dev
Status: Postponed (maintainer needs more info) » Active

Wow, so are you saying that if we change the font the bug goes away? Really? That would be most interesting. Certainly we can put widths on the form inputs. Has anyone seen this issue with anything other than search block, really like to see a block build with webform or some module just to see if this is more generic (I would think that it is).

8.x is open now so fixes go to D8 then backport to D7.

bluegray’s picture

On further investigation, the issue is reported in this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=491114
The font file for Lucida Grande in circulation reports a much wider character width than it should, which causes Firefox to make the text input boxes too wide when width is only specified in the size attribute.

Replacing the faulty font file fixes the issue.

Jeff Burnz’s picture

Would someone be so good as to test with Lucida Sans, its already in the stack and if the changes is cosmetically minor then I have no problem changing this, looks like a real edge case bug that affects very few users but easy enough for us to workaround without sacrificing anything.

bluegray’s picture

Lucida Sans is not installed by default on Ubuntu, so should degrade gracefully to the next available font. I did test with a copy of Lucida Sans I found on an old install (LSANS.TTF) and it displays fine.

sunchaser’s picture

Version: 8.x-dev » 7.x-dev
FileSize
300.47 KB

confirming the bug.
Attached is a screenshot of the Drupal.org login page as I see it on my Firefox 4.0.1

fixed the issue on my own Drupal 7 install by changing the order of the Lucida fonts. (see code herunder)
in Bartik's "css/style.css"

input,
textarea,
select,
a.button {
  font-family: "Lucida Sans Unicode", "Lucida Grande", Verdana, sans-serif;  /* was font-family: "Lucida Grande", "Lucida Sans Unicode", Verdana, sans-serif; */
}

Not sure if Lucida Sans is installed on all systems tho and will therefor degrade gracefully.

sunchaser’s picture

Version: 7.x-dev » 8.x-dev

updated version (apologies for the initial change)

bluegray’s picture

@sunchaser can you post the md5sum of your Lucida Grande font file?

sunchaser’s picture

should I have mentioned I'm not on Ubuntu ? (just windows xp here)
completely in the dark on how I could provide the md5sum of that ttf file ...
If you tell me what to do , I'd gladly help you out obviously.

a.ross’s picture

Why not apply css to the input element:

input {
  max-width: 100%;
}

That works for me and is better than an explicit size (will work in all scenarios).

Jeff Burnz’s picture

a.ross - sounds like a plan to me, its what I'm doing now all the time also.

bluegray’s picture

@sunchaser You can use this (or a number of other utilities) to generate the md5 sum of that file: http://www.winmd5.com/

a.ross’s picture

@Jeff Burnz: alright good to hear. I suppose you don't need me to create a patch :)
I'd be willing to nevertheless.

Jeff Burnz’s picture

If you can create a patch for review that would be great!

a.ross’s picture

Ok, how about this.

Anonymous’s picture

Status: Active » Needs work
Issue tags: +Novice

I tested the patch and it works. However, the comment needs to be changed to match the coding standards, as the other comments in the file do. For example:

/**
 * Markup free clearing.
 *
 * @see http://perishablepress.com/press/2009/12/06/new-clearfix-hack
 */

I would also move the block to another place in the file, closer to similar CSS rules... perhaps above or below the "Prevent text wrapping" rule.

synth3tk’s picture

Status: Needs work » Needs review
FileSize
458 bytes

Markup changed.

droplet’s picture

Status: Needs review » Needs work

Tested on Ubuntu FF4.0 without patch, it's fine. Is it only for FF3.6 ?? Please document it :).

kim.pepper’s picture

Title: Fix long input form elements » Fix long input form elements with Firefox on Linux (3.6.8 as shipped with Ubuntu Lucid)

Updating issue title

darrylmabini’s picture

FileSize
160.63 KB

Hello ma'am/sir,

How about if the input has size attribute? like this screenshot, In other browser like chrome it not happen.

I'm using Firefox 11.0, Linux (Ubuntu). Drupal 7 - but here says dup http://drupal.org/node/881264, that's why I post here.

here the example, what I mean:
input text overlap in firefox

darrylmabini’s picture

I solved this in my other theme by:

/**
 * Without declaring the font size in outer element of the input it will not work
 */
.form-item {
  font-size: 12px;
}

input {
  font: inherit;
  max-width: 100%;
}

I don't know why but it works, strange.

not good in css, maybe not the solution.

yashadev’s picture

Setting the form width to 100% would probably be a better idea than setting a fixed width.. am I wrong?

socketwench’s picture

Issue summary: View changes
Issue tags: -Novice

Novice issue cleanup.

emma.maria’s picture

Status: Needs work » Postponed (maintainer needs more info)

No one has touched this issue in a really long time. If this is still a current issue please feel free to poke me and reopen.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

pameeela’s picture

Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)
Issue tags: +Bug Smash Initiative

Thanks for reporting this issue and thanks to everyone who contributed. We rely on issue reports like this one to resolve bugs and improve Drupal core.

As part of the Bug Smash Initiative, we are triaging issues that are marked "Postponed (maintainer needs more info)".

Given that this issue was logged in 2011 and no work has been done on it since 2012, I'm marking the issue "Closed (cannot reproduce)". If anyone can provide complete steps to reproduce the issue (starting from "Install Drupal core"), document those steps in the issue summary and set the issue status back to "Active".