comment_user_cancel() should use comment_save() [#814884]

Comment	File	Size	Author
#7	814884.patch	1.61 KB	catch

#4	814884.patch	1.57 KB	catch

#2	814884.patch	1.57 KB	catch

Comment #1

catch

he/him

English

CreditAttribution: catch commented 1 June 2010 at 15:15

Status:

Active

» Needs review

There's an additional bug - when the comments are unpublished, the last_comment_uid should fall back to the uid of the most recent published node, not 0.

Either way this patch changes it to do a comment_load_multiple() then comment_save(). It does not implement batch API due to the various issues discussed in #89181: Use queue API for node and comment, user, node multiple deletes - neither queue, nor batch, nor neither are good options.

Log in or register to post comments

Comment #2

catch

he/him

English

CreditAttribution: catch commented 1 June 2010 at 15:16

File	Size
814884.patch	1.57 KB

Log in or register to post comments

Comment #3

sun

German

Karlsruhe

CreditAttribution: sun commented 1 June 2010 at 16:06

Status:

Needs review

» Needs work

+++ modules/comment/comment.module	1 Jun 2010 15:10:42 -0000
@@ -1323,25 +1323,19 @@ function comment_node_search_result($nod
+      $comments = comment_load_multiple(array(), array('cid' => $account->uid));
...
+      $comments = comment_load_multiple(array(), array('cid' => $account->uid));

s/cid/uid/

79 critical left. Go review some!