user_file_delete() should use user_save()

Patch attached to replace the current query with a call to user_save.

Sure. But is there any chance of infinite loop. Could user_file_delete get called during a user_save()?

Guessing this is a problem in 8.x. The current method has some performance problems you get a query on the user table when any file is deleted. We've got 500,000 users on a site I'm working on and file deletions are crawling. I wonder if we could look at the {file_usage} data instead.

Oh... I guess that's because there's no index on picture.

I created #1348758: Add an index to {users}.picture so user_file_delete() isn't insanely slow for the picture index issue.

Re #2: Good guess, @moshe! :)
Here's user_save():

        // Delete the previous picture if it was deleted or replaced.
        if (!empty($account->original->picture->fid)) {
          file_usage_delete($account->original->picture, 'user', 'user', $account->uid);
          file_delete($account->original->picture);
        }

#1: 814874-user-file-delete.patch queued for re-testing.

Retesting against latest HEAD since it has been over a year.

User picture is now a field, it is not managed by the user table in D8.

Changing to Drupal 7

- use patch
patch
- Fresh install
- Go to your account and upload a profile picture
- Execute a bit of PHP...

$account = user_load(1);
user_save($account);

- No more profile picture.

I will work on a patch, but feel free to write a new test if anyone has time.

- use patch
patch

The issue where this patch comes from already addresses #935592: User picture is deleted after calls to user_save().

This issue is about invoking entity hooks.

If your pictures are still getting deleted due to user_save(), then you should re-open the other issue/open new issue.