Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-on from #553298: Redesign the 'Manage Display' screen.
At admin/structure/types/manage/article/comment/display, there's a fieldset for Custom display settings, but this is pointless as there's only one view mode anyway.
Comment | File | Size | Author |
---|---|---|---|
#17 | field-ui-813750-17-tests-only.patch | 1.31 KB | dcam |
#17 | field-ui-813750-17.patch | 4.19 KB | dcam |
#12 | 813750-12-tests-only.patch | 1.77 KB | swentel |
#12 | 813750-12-fix.patch | 2.43 KB | swentel |
#9 | 813750-9.patch | 2.45 KB | swentel |
Comments
Comment #1
joachim CreditAttribution: joachim commentedPatch.
Comment #2
yched CreditAttribution: yched commentedWell, theoretically, you might want to have different settings for 'the only current view mode' and for 'default' (i.e the settings that will be used for any newly enabled view mode).
Agreed that it's an edge case, and that the patch makes things less confusing.
Patch doesn't seem to apply for me, though. Can you reroll ?
Comment #3
yoroy CreditAttribution: yoroy commentedsubscribe
Comment #5
nils.destoop CreditAttribution: nils.destoop commentedRe-rolling this patch for latest code. Although i agree with yched, theoretically, you might want to have different settings for the default view mode, and the only custom view mode.
Comment #6
nils.destoop CreditAttribution: nils.destoop commentedComment #7
swentel CreditAttribution: swentel commentedWell it makes sense though it there's only one known view mode, eg, the user afaik comes with only one by default in core.
Comment #9
swentel CreditAttribution: swentel commentedRe-uploading, some weird characters in the patch (at the end of the file) - if this comes through, don't credit me for it.
Comment #10
swentel CreditAttribution: swentel commentedTested this, works fine.
Setting rtbc, let's check what the core committers think of this.
Comment #11
catchMakes sense. Committed/pushed to 8.x.
Comment #12
swentel CreditAttribution: swentel commentedAh this triggers a notice, bad testing from me, sorry. New patches fixing that + tests, first one should fail, second one will come back green.
Comment #13
yched CreditAttribution: yched commentedCorrect :-)
Comment #14
webchickThanks for the bug fix and the patch, committed and pushed to 8.x.
Comment #16
joachim CreditAttribution: joachim commentedCan this be backported?
Comment #17
dcam CreditAttribution: dcam commentedBackported #9 and #12 to D7. I removed the t() from the assert message in the test.