Follow-on from #553298: Redesign the 'Manage Display' screen.

At admin/structure/types/manage/article/comment/display, there's a fieldset for Custom display settings, but this is pointless as there's only one view mode anyway.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim’s picture

Status: Active » Needs review
FileSize
2.44 KB

Patch.

yched’s picture

Status: Needs review » Needs work

Well, theoretically, you might want to have different settings for 'the only current view mode' and for 'default' (i.e the settings that will be used for any newly enabled view mode).

Agreed that it's an edge case, and that the patch makes things less confusing.

Patch doesn't seem to apply for me, though. Can you reroll ?

yoroy’s picture

Version: 7.x-dev » 8.x-dev
Issue tags: +Usability

subscribe

nils.destoop’s picture

Re-rolling this patch for latest code. Although i agree with yched, theoretically, you might want to have different settings for the default view mode, and the only custom view mode.

nils.destoop’s picture

Status: Needs work » Needs review
swentel’s picture

Well it makes sense though it there's only one known view mode, eg, the user afaik comes with only one by default in core.

Status: Needs review » Needs work

The last submitted patch, 813750_4_hide_single_custom_display.patch, failed testing.

swentel’s picture

Status: Needs work » Needs review
FileSize
2.45 KB

Re-uploading, some weird characters in the patch (at the end of the file) - if this comes through, don't credit me for it.

swentel’s picture

Status: Needs review » Reviewed & tested by the community

Tested this, works fine.
Setting rtbc, let's check what the core committers think of this.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Makes sense. Committed/pushed to 8.x.

swentel’s picture

Status: Fixed » Needs review
FileSize
2.43 KB
1.77 KB

Ah this triggers a notice, bad testing from me, sorry. New patches fixing that + tests, first one should fail, second one will come back green.

yched’s picture

Status: Needs review » Reviewed & tested by the community

Correct :-)

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for the bug fix and the patch, committed and pushed to 8.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

joachim’s picture

Version: 8.x-dev » 7.x-dev
Status: Closed (fixed) » Patch (to be ported)

Can this be backported?

dcam’s picture

Status: Patch (to be ported) » Needs review
FileSize
4.19 KB
1.31 KB

Backported #9 and #12 to D7. I removed the t() from the assert message in the test.

  • catch committed 289fbb1 on 8.3.x
    Issue #813750 by joachim, zuuperman, swentel: Fixed don't show 'Custom...
  • webchick committed a56bd47 on 8.3.x
    Issue #813750 by swentel, joachim, zuuperman: Fixed don't show 'Custom...

  • catch committed 289fbb1 on 8.3.x
    Issue #813750 by joachim, zuuperman, swentel: Fixed don't show 'Custom...
  • webchick committed a56bd47 on 8.3.x
    Issue #813750 by swentel, joachim, zuuperman: Fixed don't show 'Custom...

  • catch committed 289fbb1 on 8.4.x
    Issue #813750 by joachim, zuuperman, swentel: Fixed don't show 'Custom...
  • webchick committed a56bd47 on 8.4.x
    Issue #813750 by swentel, joachim, zuuperman: Fixed don't show 'Custom...

  • catch committed 289fbb1 on 8.4.x
    Issue #813750 by joachim, zuuperman, swentel: Fixed don't show 'Custom...
  • webchick committed a56bd47 on 8.4.x
    Issue #813750 by swentel, joachim, zuuperman: Fixed don't show 'Custom...

  • catch committed 289fbb1 on 9.1.x
    Issue #813750 by joachim, zuuperman, swentel: Fixed don't show 'Custom...
  • webchick committed a56bd47 on 9.1.x
    Issue #813750 by swentel, joachim, zuuperman: Fixed don't show 'Custom...