Follow-Up issue of #793604: DBTNG JOINs are close to useless.

Once that is commited, we need to find places in core where the current code could lead to bugs and remove ugly workarounds which I added since I could not came up with a a real solution :)

CommentFileSizeAuthor
#1 convert_to_alias.patch8.54 KBBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Active » Needs review
FileSize
convert_to_alias.patch8.54 KB

Attaching a first, untested patch.

I only converted those instances which actually need dynamic alias names. In case of book.module, I removed the variables, since they weren't used consistently and are not required.

Crell’s picture

Crell CreditAttribution: Crell commented
Status: Needs review » Reviewed & tested by the community

Bot likes it, looks OK to me on visual inspection. I like how it even managed to eliminate some variables in the process. :-)

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.