Improve 'empty' state of Dashboard blocks [#787924]

Comment	File	Size	Author
#7	dashboard-empty-787924-7.patch	976 bytes	David_Rothstein

#5	Screen shot 2011-01-08 at 11.25.32 PM.png	49.22 KB	Jody Lynn

Comment #1

yoroy CreditAttribution: yoroy commented 2 May 2010 at 20:23

Dashboard | d7

The totally empty one for 'Active forum topics' is probably a bug worthy of its own issue?

As you can see, the 'recent content' block does have its own specific 'empty' message.

Log in or register to post comments

Comment #2

yoroy CreditAttribution: yoroy commented 2 May 2010 at 20:36

Issue tags:

+Usability

tag

Log in or register to post comments

Comment #3

dmitrig01 CreditAttribution: dmitrig01 commented 6 May 2010 at 00:26

Assigned:

Unassigned

» dmitrig01

Wow this is bad. no translation either

Log in or register to post comments

Comment #4

yoroy CreditAttribution: yoroy commented 6 May 2010 at 06:07

#504428: Roll-out 'Empty text' pattern to other admin pages. for reference

Log in or register to post comments

Comment #5

Jody Lynn

she/her

English

CreditAttribution: Jody Lynn commented 9 January 2011 at 04:31

File	Size
Screen shot 2011-01-08 at 11.25.32 PM.png	49.22 KB

Recent comments now shows an empty message.

The ones that show (empty) are blocks that outside of the dashboard would not appear at all (nothing is returned by hook_block_view when they are empty), whereas others return empty $block['contents'] and end up with blank content here.

I think nothing at all is better than (empty).

Log in or register to post comments

Comment #6

dmitrig01 CreditAttribution: dmitrig01 commented 10 January 2011 at 00:40

Assigned:

dmitrig01

» Unassigned

Log in or register to post comments

Comment #7

David_Rothstein CreditAttribution: David_Rothstein commented 30 January 2011 at 16:55

Status:

Active

» Needs review

File	Size
dashboard-empty-787924-7.patch	976 bytes

I'm not sure there is much we can do about this issue in the dashboard module itself. The dashboard does need to have some handling for blocks that are truly empty (i.e., would not otherwise display at all). To make individual blocks display but with "No X available" there needs to be issues filed against the modules that provide those blocks, I think.

The forum module block is a weird special case and does seem like its own bug. I filed an issue with a patch to fix that here: #1045390: Forum module blocks display with no content when they are empty

Attached is a patch that fixes the fact that "(empty)" wasn't translated, though. It actually was translated in one place in the code, but not in this one for some reason.... so this doesn't add any new strings. We can at least get that out of the way quickly.