This is a follow up to #351249: Finer control over the Parent Menu select box where we moved this setting to structure>content types.

CommentFileSizeAuthor
#5 716792.patch1.63 KBagentrickard
#1 menu.patch995 bytesbleen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bleen’s picture

bleen CreditAttribution: bleen commented
Status: Active » Needs review
FileSize
menu.patch995 bytes

here's a quick patch

JODA-RE75VBW0D4’s picture

JODA-RE75VBW0D4 CreditAttribution: JODA-RE75VBW0D4 commented

#1: menu.patch queued for re-testing.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard commented
Status: Needs review » Reviewed & tested by the community

Confirmed.

Dries’s picture

Dries CreditAttribution: Dries commented

Care to provide a bit more background/information -- especially given that this patch is marked 'critical'?

Menu.module still seem to use this variable in: ./modules/menu/menu.module: $menu_name = variable_get('menu_default_node_menu', 'navigation');

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard commented
Status: Reviewed & tested by the community » Needs review
FileSize
716792.patch1.63 KB

The background is all in #351249: Finer control over the Parent Menu select box, and that looks like an oversight in the current patch.

Revised to catch the one holdover usage of the old variable.

In effect, default menus are now content-type specific.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

This was not documented in the update guide, now added http://drupal.org/update/modules/6/7#menu_default_node_menu

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

This change is missing an upgrade path. Critical issue opened at #761648: Menu D6->D7 upgrade doesn't maintain node-menu configuration (f.k.a.: Menu items disappear after upgrade or manual menu entry).