This patch cleans up a few small things, most of which were noted in reviews at #610234: Overlay implementation:

1. Kills a blank line in overlay-parent.js
2. Removes a javascript theme function that we don't seem to be using at all
3. Clarifies the use of a hidden form field in overlay.module that appears without a #value property

CommentFileSizeAuthor
#5 updated-overlay-cleanup_0.patch1.28 KBAnonymous (not verified)
#1 overlay-cleanup.patch2.13 KBDavid_Rothstein
overlay-cleanup.patch1.89 KBDavid_Rothstein
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
FileSize
overlay-cleanup.patch2.13 KB

Looks like I missed one of the blank lines that was supposed to be cleaned up.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Priority: Normal » Minor
ksenzee’s picture

ksenzee
she/her
Location Seattle area
CreditAttribution: ksenzee commented
Status: Needs review » Reviewed & tested by the community

Great. Although if #655614: Changes made by submitting a form in the overlay are not reflected when the window automatically closes goes in, as it should, this will need a reroll.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs work

Reeeee-roll.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
FileSize
updated-overlay-cleanup_0.patch1.28 KB

I believe i cleaned up the conflict.

ksenzee’s picture

ksenzee
she/her
Location Seattle area
CreditAttribution: ksenzee commented
Status: Needs work » Reviewed & tested by the community

Looks good! Thanks nenne.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.