(not really an overlay.module issue, but the overlay is most affected by this)

Currently we have this:

function node_admin_paths() {
  $paths = array(
    'node/*/add' => TRUE,
    'node/*/edit' => TRUE,
    'node/*/delete' => TRUE,
    'node/add' => TRUE,
    'node/add/*' => TRUE,
  );
  return $paths;
}

@webchick pointed out that the node revisions page belongs there, for example, since its sort-of administrative-y. Perhaps some others belong there too (book outlines?).

(Note that none of this will have an actual effect on the theme that shows in the overlay unless #615138: Some pages display in the overlay in a non-adminstrative theme goes in also.)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

David_Rothstein’s picture

Status: Active » Needs review
FileSize
2.01 KB

Here's a patch.

After reviewing all node-related paths in core, I decided that book outlines and content translation probably made sense to add here as well. I thought about the statistics module also (node/*/track), but that one seemed like it probably shouldn't make the cut. Obviously there are gray areas here, and contrib modules can refine the list if they want to.

Note that most of these are local tasks, and frankly the experience of clicking on a local task and having an overlay pop up is pretty weird. We should think later about whether many of these local tasks should become local actions instead....

Finally, this patch also removes node/*/add from the list, since as far as I know that path doesn't even exist in core :)

David_Rothstein’s picture

Something funny happened there. Let's attach the patch again.

Re-test of node-related-admin-paths-655508-1.patch from comment #3 was requested by Dave Reid.

Dave Reid’s picture

Status: Needs review » Reviewed & tested by the community

I like it and looks good.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.