Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amye’s picture

Category: bug » support
Status: Needs review » Active

Generally, I like it.
No changes from me.
Mistakenly marked 'active' instead of 'needs review'.

amye’s picture

Status: Active » Needs review

Changing status to 'needs' review'.

arianek’s picture

Category: support » bug
Status: Needs review » Active
arianek’s picture

Status: Active » Needs review
batigolix’s picture

i would mention a couple of well known openid providers (yahoo, flickr, google?)

punctuation:
"eg. myusername.openidprovider.com"
=>
"e.g., myusername.openidprovider.com"

instead of
"At no point does your site record, or need to record the user's OpenID password."
i would write
"At no point does your site record the user's OpenID password."

this help text seems more detailed than other help texts we've writing before. but i like it. maybe we should write them all like this one (for drupal 9 :)

batigolix’s picture

Status: Needs review » Needs work

forgot the status

batigolix’s picture

Status: Needs work » Needs review
FileSize
5.23 KB

the module name stays capitalized as the official name of OpenID is OpenID (with capital O)

batigolix’s picture

FileSize
4.14 KB

improved patch

arianek’s picture

FileSize
5.09 KB
107.38 KB

removed the mentions of microsoft, etc. the openid site has info on that stuff. cleaned up the language a bit more, and a couple more code tweaks.

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Looks good.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Cool, committed to HEAD!

This one contains a bit more "how to" in the "Uses" section than other pages I've seen. I don't think this is necessarily a bad thing, particularly with modules that are fairly technical, like this one. We might also want to employ a similar strategy over at #640216: Help File Fixup: Update status module.

Status: Fixed » Closed (fixed)
Issue tags: -Documentation, -Help text, -drupal7, -d7docs, -d7help

Automatically closed -- issue fixed for 2 weeks with no activity.