Ditch a lot of narly form array => table theming code by using our D7 fapi element - #tableselect. Note that comment admin already uses #tableselect.

CommentFileSizeAuthor
#8 595982-8-fix-notice.patch420 bytesksenzee
#6 tableselect.diff11.32 KBchx
#2 tableselect.diff11.32 KBmoshe weitzman
tableselect.diff11.32 KBmoshe weitzman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs work » Needs review
FileSize
tableselect.diff11.32 KB

Fix test failures. Note that both of these forms already have test coverage.

Status: Needs review » Needs work

The last submitted patch failed testing.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Issue tags: +clean path

Oh! Pretty! Ignore the failing tests: #472820: drupal_load_stylesheet_content() removes whitespace improperly, creating invalid CSS ......... Uhh, I applied the wrong tag. Whoops.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Reviewed & tested by the community

Good enough for me.

chx’s picture

chx CreditAttribution: chx commented
FileSize
tableselect.diff11.32 KB

Reuploading.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

ksenzee’s picture

ksenzee
she/her
Location Seattle area
CreditAttribution: ksenzee commented
Status: Fixed » Needs review
FileSize
595982-8-fix-notice.patch420 bytes

On admin/content, when there are no nodes, I'm now getting a notice that $options is undefined.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -clean path

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +clean path

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.