Language choice during installation - Drupal(minimal) profile skips language choice [#562722]

Currently D7 lets you choose between two installation profiles. Drupal and Drupal minimal.

Choosing Drupal leads you to the "choose language" page (as usual)

Choosing Drupal (minimal) skips that phase and takes you straight to database configuration.

I think that choosing the language should always be an option, even in the bare bones case.

Comment	File	Size	Author
#4	installer-language-selection-562722-4.patch	1.89 KB	David_Rothstein
#4

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

davyvdb CreditAttribution: davyvdb commented 29 August 2009 at 18:48

Category:

bug

» feature

I think minimal is minimal. For languages, the language module needs to be installed. This is not minimal anymore. I'd say won't fix.

Comment #2

ronald_istos CreditAttribution: ronald_istos commented 29 August 2009 at 20:54

I get your point but a different language for a non-english speaker is not an option it is a necessity - Could we ask the question and if the answer is something other then English only then install the language module?

It is also a public image thing - is Drupal truly international or mostly for English speakers? If the only other option for installation skips the language question it means that all non-english speakers cannot "benefit" from whatever that installation offers (i.e. barebones except language).

Comment #3

ronald_istos CreditAttribution: ronald_istos commented 29 August 2009 at 20:54

Category:

feature

» bug

Comment #4

David_Rothstein CreditAttribution: David_Rothstein commented 17 November 2009 at 05:21

Status:

Active

» Needs review

File	Size
installer-language-selection-562722-4.patch	1.89 KB

Although the code comment suggests that this behavior is intentional, I agree that it's a bug. I can't think of any reason to special-case the default core profile above all others (including contrib profiles) with regard to this particular feature...

The attached patch makes the language selection screen appear by default for all profiles.

Comment #5

nkmani CreditAttribution: nkmani commented 17 November 2009 at 06:16

Status:

Needs review

» Reviewed & tested by the community

After the patch, minimal install does prompt for the language of choice; after the selection continues the minimal mode of installation properly. Works!

Comment #6

David_Rothstein CreditAttribution: David_Rothstein commented 17 November 2009 at 13:16

Status:

Reviewed & tested by the community

» Needs review

OK, it actually turns out to be a bit more complicated than I thought. Here is the code for finding which languages to show in the selectable list on the initial "choose language" screen:

/**
 * Find all .po files for the current profile.
 */
function install_find_locales($profilename) {
  $locales = file_scan_directory('./profiles/' . $profilename . '/translations', '/\.po$/', array('recurse' => FALSE));
  array_unshift($locales, (object) array('name' => 'en'));
  return $locales;
}

So even if you go through all the instructions on the longer language selection screen and download a language, you'll still never get an option to install with it unless it happens to put a .po file into your install profile's directory. Presumably, that's why the current code treats the default profile specially - in general, we aren't going to expect that translations know about every contrib profile that exists. So with the current patch, the language selection screen won't work correctly when you choose other profiles.

Except... none of the above behavior actually makes any sense at all :) 100% of the text that is shown on the screen during the installer is contained within install.php, install.inc, or elsewhere in the main part of core. An install profile can override that text if it wants to (and putting translations for that overridden text in the profile directory makes sense), but having translators put translations of core text in a profile directory does not make any sense - it should live somewhere else. Changing that would make it possible to fix this bug properly. (In addition, there's a question of whether you should really be prevented from importing a language during installation just because the language doesn't translate the installer text - still seems like it might be useful if it translates the other screens you see on your Drupal site immediately after the installer has run....)