Migrate overall node admin theme setting to per-content type

Interesting solution. Can we make this a multi-valued type so that I could hook into it in contrib and make my own type of content type?

I wonder if the bot is broken or HEAD is broken? Can't hurt to try the bot one more time...

Josh

I'm not sure if this is a good idea or not. Copying what I wrote at http://drupal.org/node/511258#comment-1873964:

Although I realize the implementation details might be particularly tricky, I honestly think the ideal thing to do here is that it depends where you clicked from. If you're in the overlay and click on a create content link within that, I think you should stay in the overlay/admin theme. Whereas if you're on the "main site" and click such a link, I think you should stay in the main site theme.

I honestly don't think the content type matters much. Just because I have forums on my site that regular users can submit to doesn't necessarily mean that I, as a site administrator, automatically want to go into "regular user mode" every time I myself submit a forum post.

Also, as discussed in that issue, we need to keep in mind how this will interact with things like the (proposed) Create Content block. If there are per-content-type settings for this, it is going to get tricky to figure out what links show in that block and what links don't - and whether you "jump themes" when you click on a link, etc.

All in all, sounds like a fun issue :)

Note that I have a patch at #553944: Define hook_menu_get_item_alter() as a reliable hook that runs before the page is doomed which started off as an attempt to fix a totally unrelated bug, but might be useful for this issue too since it would make granular per-page theming a fair amount easier.

I still sort of like the idea of having it depend on where you clicked from, since I think that is the only solution that would really minimize the "jumping" between the overlay and non-overlay (without restricting which links can appear where).

However, another solution which might be worth thinking about would be to make it depend on a permission. So "regular users" adding content would see it in the main site theme, while "admin users" would see it in the overlay. This would solve the problem of having to have two different lists of content types - each individual user would have consistent behavior for any content creation/editing link they clicked on, so they could all appear in the same list. However, it would also mean that an admin user wouldn't be able to experience content creation via the same screen that a regular user would.

I like where David is going here. The experience should be uniform across users. Having "add" take on two different interfaces would cause confusion. If you can do this by role, at least the admin will always have the same experience until he logs out.

This is still a problem. Currently, if you have forum topic creation permissions for regular users, they'll see the Seven theme on the node creation page when submitting forum topics as far as I've seen.

Yes, this is a feature of the node admin theme setting (in D6 too I think?) which makes it not useful for a large number of sites :)

If it comes down to it, we could probably just stop turning that setting on in the standard install profile in D7, since when all is said and done the overlay is going to handle its own theming anyway (it's only different now due to a bug).

See also #669510: Merge administration theme with hook_admin_paths() where there is an effort underway to do something similar to what I mentioned above (i.e. move the entire admin theme in Drupal 7 to be permission-based in addition to page-based), which would solve this problem completely as well.

admin-theme-node-type.patch queued for re-testing.

BUMP. As far as I can see this is still a problem. Is the community still interested? This would require

1. A config schema change
2. A change to NodeTypeForm
3. A new service tagged with theme_negotiator