Attached patch should fix the test failures on SQLite mentioned in http://drupal.org/node/303965#comment-1519896

CommentFileSizeAuthor
field_test_fix.patch883 bytesyched
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

moshe weitzman’s picture

Status: Needs review » Reviewed & tested by the community
webchick’s picture

Status: Reviewed & tested by the community » Needs work

Hm. With this patch and SQLite I still get 383 passes, 10 fails, and 120 exceptions in test.text.

The badness starts with INSERT INTO {test_entity} (ftvid, fttype) VALUES (?, ?) - Array ( [0] => 0 [1] => test_bundle ) SQLSTATE[23000]: Integrity constraint violation: 19 column ftvid is not unique in drupal_write_record() and then goes on to fail the "Entity was created" check in TextFieldTestCase->_testTextfieldWidgets(), and then all hell breaks loose. ;)

I have no idea how else to share test results other than a big-ass 1.5 MB screenshot, so here ya go: http://img.skitch.com/20090426-enhtgucf3g99n4cs6f1g3sbhyt.png

There are instructions though for installing on SQLite in INSTALL.sqlite.txt and they work just dandy.

webchick’s picture

I should note that with Damien's patch at http://drupal.org/node/303965#comment-1519896 the tests pass fine, but Moshe said that those lines were removed because of an edge case. Possible solutions:

1. Commit it anyway, and if said edge case rears its ugly heads, write tests for it so they don't again. ;)
2. Come up with a new idea, now that it's more clear what's causing the test to fail.

webchick’s picture

Btw, it's still a bit unclear to me as to whether or not we need this fix in addition to Damien's. If we're fixing a specific bug here, we should probably write tests for it.

yched’s picture

webchick’s picture

Status: Needs work » Fixed

Cool. Committed to HEAD. Thanks. :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.