Note: I'm going to provie a patch when this module has been converted to DBTNG, see #394560: DBTNG: Statistics module.
I was wondering if I'm the only one who is confused that the "Popular content" block actually contains three different things, which need to be enabled explicitly on the block configuration page? I had to look into the code to understand that I have to go to the configuration page to "enable" it ;)
This is also unflexible because you can't place the "Last viewed" and "Popular: Today" in different regions or change the order of those.
I'd suggest to split them up into three distinct blocks and also set the default number of nodes to 5.
Possible names:
- Popular content: Today
- Popular content: All time
- Last viewed content
Comment | File | Size | Author |
---|---|---|---|
#12 | 431028-12.patch | 9.74 KB | Wim Leers |
#5 | 431028.popular-content-split-blocks.005.patch | 10.63 KB | karschsp |
#3 | 431028.popular-content-split-blocks.003.patch | 6.48 KB | karschsp |
#2 | 431028.popular-content-split-blocks.002.patch | 6.55 KB | karschsp |
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedYeah, this is a really confusing user interaction. I'm going to change this to 8.x-dev.
Comment #2
karschsp CreditAttribution: karschsp commentedHere's a patch that splits these blocks up.
Comment #3
karschsp CreditAttribution: karschsp commentedFixing white space. Sorry...
Comment #5
karschsp CreditAttribution: karschsp commentedHere's one with updated tests.
Comment #6
thedavidmeister CreditAttribution: thedavidmeister commentederror: patch failed: core/modules/statistics/statistics.module:312
error: core/modules/statistics/statistics.module: patch does not apply
error: core/modules/statistics/statistics.test: No such file or directory
Comment #12
Wim LeersAn issue that @Berdir created almost 9 years ago! :D Lovely!
We can't change the existing block — but we can provide new blocks that do what @Berdir asked for and @linclark agreed with.
Comment #21
quietone CreditAttribution: quietone at PreviousNext commentedStatistics is approved for removal. See #3266457: [Policy] Deprecate Statistics module in D10 and move to contrib in D11
This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.
It will be moved to a contributed Statistics project once the project is created and the Drupal 11 branch is open.