remove admin/content/search - it's broken

This bug is still present in beta2. I think Ber is right, this page is redundant unless the advanced search is only available to admins.

That page also has some help strings which talk about wildcards. According to http://drupal.org/node/41510 they're no longer supported, so that needs to be fixed, too.

moving to cvs.

hi,

here is the patch for search.module

*** modules/search.module 2006-05-10 13:51:44.000000000 +0530
--- modules/search.module1 2006-05-10 12:54:45.000000000 +0530
***************
*** 360,364 ****
// With the exception of the rules above, we consider all punctuation,
// marks, spacers, etc, to be a word boundary.
! //$text = preg_replace('/['. PREG_CLASS_SEARCH_EXCLUDE . ']+/u', ' ', $text);

return $text;
--- 360,364 ----
// With the exception of the rules above, we consider all punctuation,
// marks, spacers, etc, to be a word boundary.
! $text = preg_replace('/['. PREG_CLASS_SEARCH_EXCLUDE . ']+/u', ' ', $text);

return $text;
***************
*** 737,741 ****

// Build word-index conditions for the first pass
! $query2 = substr(str_repeat("i.word like '%s' OR ", count($arguments2)), 0, -4);

return array($query, $arguments, $query2, $arguments2, $matches);
--- 737,741 ----

// Build word-index conditions for the first pass
! $query2 = substr(str_repeat("i.word = '%s' OR ", count($arguments2)), 0, -4);

return array($query, $arguments, $query2, $arguments2, $matches);

here is the patch for node.module

*** modules/node.module 2006-05-10 12:55:24.000000000 +0530
--- modules/node.module1 2006-05-10 12:53:44.000000000 +0530
***************
*** 698,702 ****

// Do search
- $keys=str_replace("*","%",$keys);
$find = do_search($keys, 'node', 'INNER JOIN {node} n ON n.nid = i.sid '. $join1 .' INNER JOIN {users} u ON n.uid = u.uid', $conditions1 . (empty($where1) ? '' : ' AND '. $where1), $arguments1, $select2, $join2, $arguments2);

--- 698,701 ----

save this patch and patch the node.module and search.module file.

it will work

Please attach a patch. It's difficult to test patches that aren't attached.

OK the search page at admin/content/search does absolutely nothing now - both normal and advanced search. Page refreshes, no search is run.

This patch just removes the menu item and associated function completely from node module.

Two arguments for removing rather than trying to correct it:

1. http://drupal.org/node/146466 needs to go in (and I double checked that it has no effect on this being broken or not).

2. This is a two year old issue, with a handful of posts on it. I was unable to find any duplicate issues or forum topics with a cursory search, so from that I think we can assume that almost no-one actually uses admin/content/search.

3. If search is enabled, there's usually a search box/link somewhere on every page anyway.

Patch doesn't apply for me.

I agree that the right option is to remove this menu item. The righ way to implement content search is to remake the filter functionality on /admin/content/node to a filter/search functionality.

hmm re-roll.

patch applies for me on debian but it says "stripping trailing CRs". I'm patching on windows with notepad++ and tortoise so probably due to that. I don't have cvs set up on my vps, so probably not able to re-roll cleanly. Back to needs work and hopefully someone can take this up.

I see. Changed the line endings to UNIX and patch applies.

(catch: There is a handbook page dedicated to creating patches on Windows, or you can contact me offlist and I give you my killer Windows patch setup)

changing status. fajerstarter I'll check the handbook page again, otherwise I might take you up on that.

I should mention that I did test the patch and it works a expected (as always, enable/disable a module to re-build the menu). Don't know the the code enough to say if all trails of this functionality is removed.

I did a search of the whole drupal directory for as many references as I could find, but yeah it could do with someone who has more familiarity to see if there's anything left.

Indeed, I checked the search functionality and it does not seem like doing anything well. It is also the same interface as the usual search page. I also grepped the Drupal source for some more locations this is used or referenced, but found nothing:

gabor$ grep -R node_admin_search *
modules/node/node.admin.inc:function node_admin_search() {
modules/node/node.module:      'page callback' => 'node_admin_search',
gabor$ grep -R "admin/content/search" *
modules/node/node.admin.inc:  return drupal_get_form('search_form', url('admin/content/search'), $keys, 'node') . search_data($keys, 'node');
modules/node/node.module:    case 'admin/content/search':
modules/node/node.module:    $items['admin/content/search'] = array(

Thanks, committed.