Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This patch depends on #374646: Popbox (Popups Lite): Adding Modal Dialogs to Confirmations. It updates garland to support the popbox effect, but adding id's to the page title and page content area in page.tpl.php. This brings garland in line with the newly polished default page.tpl.php.
Also, this patch demonstrates customizing the look of the popbox dialog in a theme, by modifying the style.css and adding popbox.js file.
Comment | File | Size | Author |
---|---|---|---|
#4 | popbox-garland.patch | 3.78 KB | starbow |
#3 | garland-popbox.png | 27.26 KB | starbow |
#2 | garland-popbox.png | 27.26 KB | starbow |
popbox-garland.patch | 2.96 KB | starbow | |
Comments
Comment #2
starbow CreditAttribution: starbow commentedHere is a screenshot (while I am hunting down the failed tests).
Comment #3
starbow CreditAttribution: starbow commentedAnd here it is again, with a change to the test to accept the new id.
Comment #4
starbow CreditAttribution: starbow commentedNo, no, the patch you fool :)
Comment #5
RobLoachI think we should provide a close icon in the CSS instead of the Drupal.t('X').
Comment #6
starbow CreditAttribution: starbow commentedI agree. I just threw the X in there to make sure it was working.
Last year I used the misc/watchdog-error.png as a close image, but it was universally rejected. Drupal could really use a set of utility icons. Not sure if this patch is the place to introduce them though.
Comment #7
alexanderpas CreditAttribution: alexanderpas commentedactually, i think we should do
Drupal.t('close')
, a close icon can always be done trough CSS, and some themes might want to show both text and icon (which is easy, since we have an id'ed<div>
and an<a>
to work with).Comment #8
Jeff Burnz CreditAttribution: Jeff Burnz commentedI assume this was posted for testing the patch in #374646 but since that didn't get in I assume this is a won't fix?