Problem/Motivation

#3266465: [policy, no patch] Remove Telephone module from core consensus is telephone module should be removed. This ticket will need to move to the META for tasks to deprecate I'm just getting things started.

There are a few tests that are using telephone but think they can be replaced

Steps to reproduce

NA

Proposed resolution

Replace/Remove any tests outside telephone that use the telephone module

Remaining tasks

Reivew

User interface changes

NA

Introduced terminology

NA

API changes

NA

Data model changes

NA

Release notes snippet

NA

Issue fork drupal-3594057

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave opened merge request !16005

smustgrave’s picture

smustgrave commented
Status: Active » Needs review

Simple enough.

smustgrave’s picture

smustgrave commented
Assigned: smustgrave » Unassigned
dcam’s picture

dcam commented

What are your thoughts on using the test_field from the field_test module instead of a link? I know that in the most recent maintainer survey there were people who thought Link should be removed from Core too. I think that's a mistake, but that's a different discussion. The point is you never know what the lifetime of a Core module is.

quietone’s picture

quietone commented

I think this is premature, the policy issue for removing telephone does not yet have all the required signoffs.

When approved, use the existing process for removing modules from core to contrib,

quietone’s picture

quietone commented

I just caught up with a slack discussion in the release manager channel and the policy and there was agreement to remove telephone from core.

I will now setup the issues for removing per the policy stated in the previous comment.

quietone’s picture

quietone commented
Parent issue: #3266465: [policy, no patch] Remove Telephone module from core » #3594196: [meta] Tasks to deprecate the Telephone module
smustgrave’s picture

smustgrave commented

@quietone sorry got a little ahead of myself.

@dcam I tried your suggestion the only one I didn't replace was core/modules/field/tests/src/Functional/ReEnableModuleFieldTest.php because the comment mentions

We use link module instead of test_field because test_field is
// hidden and does not display on the admin/modules page.

dcam’s picture

dcam commented
Status: Needs review » Needs work

...I didn't replace was core/modules/field/tests/src/Functional/ReEnableModuleFieldTest.php because the comment mentions...

Makes sense. No problem.

I found a couple of things to take another look at. I left a couple of comments for them.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Addressed the feedback, thanks!

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

My feedback was addressed. It looks good to me.