Problem/Motivation

PHPStan is failing on 11.3.x due to #3578193: CommentTokensHooks passes NULL to UrlHelper::stripDangerousProtocols() when comment homepage is not set

Steps to reproduce

Run PHPStan on 11.3.x

Proposed resolution

Fix the baseline

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

N/a

Release notes snippet

N/a

Issue fork drupal-3581997

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !15249

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
godotislate’s picture

godotislate
he/him
commented
Status: Needs review » Reviewed & tested by the community

PHPStan passes, so lgtm.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 0f281ec and pushed to 11.3.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed 0f281eca on 11.3.x 
    ci: #3581997 PHPStan is failing on 11.3.x

By: alexpott

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.