Problem/Motivation

The performance stats for AssetAggregationAcrossPagesTest are not correct and are breaking tests.
https://git.drupalcode.org/project/drupal/-/jobs/8866632 on main

 Asset Aggregation Across Pages (Drupal\Tests\demo_umami\FunctionalJavascript\AssetAggregationAcrossPages)
     ✔ Front and recipes pages
     ✔ Front and recipes pages authenticated
     ✔ Front and recipes pages editor
     ✘ Node add pages author
       ┐
       ├ Asserting ScriptBytes 3804493 is greater or equal to 3803005 and is smaller or equal to 3804005
       ├ Failed asserting that 3804493 ( is equal to 3803005 or is greater than 3803005 ) and ( is equal to 3804005 or is less than 3804005 ).
       │
       │ /builds/core/tests/Drupal/Tests/PerformanceTestTrait.php:636
       │ /builds/core/tests/Drupal/Tests/PerformanceTestTrait.php:685
       │ /builds/core/profiles/demo_umami/tests/src/FunctionalJavascript/AssetAggregationAcrossPagesTest.php:106
       ┴
    
    FAILURES!
    Tests: 4, Assertions: 41, Failures: 1.

https://git.drupalcode.org/project/drupal/-/jobs/8866667 on 11.x

Asset Aggregation Across Pages (Drupal\Tests\demo_umami\FunctionalJavascript\AssetAggregationAcrossPages)
     ✔ Front and recipes pages
     ✔ Front and recipes pages authenticated
     ✔ Front and recipes pages editor
     ✘ Node add pages author
       ┐
       ├ Asserting ScriptBytes 3811015 is greater or equal to 3809527 and is smaller or equal to 3810527
       ├ Failed asserting that 3811015 ( is equal to 3809527 or is greater than 3809527 ) and ( is equal to 3810527 or is less than 3810527 ).
       │
       │ /builds/project/drupal/core/tests/Drupal/Tests/PerformanceTestTrait.php:636
       │ /builds/project/drupal/core/tests/Drupal/Tests/PerformanceTestTrait.php:685
       │ /builds/project/drupal/core/profiles/demo_umami/tests/src/FunctionalJavascript/AssetAggregationAcrossPagesTest.php:106
       ┴
    
    FAILURES!
    Tests: 4, Assertions: 41, Failures: 1.

Steps to reproduce

Proposed resolution

Adjust number in AssetAggregationAcrossPagesTest::doTestNodeAddPagesAuthor

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3578653

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

godotislate created an issue. See original summary.

godotislate opened merge request !15064

godotislate opened merge request !15065

godotislate’s picture

godotislate
he/him
commented
Status: Active » Needs review

main MR: https://git.drupalcode.org/project/drupal/-/merge_requests/15064
11.x MR: https://git.drupalcode.org/project/drupal/-/merge_requests/15065

Likely due to #3538177: Remove jQuery UI _focusedElement and _focusTabbable from dialog Ajax.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Love/hate these tests but yes please fix

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented

Ran the 2 MR pipelines additionally 3 times each

Looks good. +1 for RTBC

  • catch committed d6212f9c on main 
    fix: #3578653 AssetAggregationAcrossPagesTest is broken

By: godotislate
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !15064

catch closed merge request !15065

  • catch committed 3f857ba7 on 11.x 
    fix: #3578653 AssetAggregationAcrossPagesTest is broken

By: godotislate

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.