Mini pager and full pager behaving differently for views loaded by ajax

one additional detail. after todays discussions, out of curiosity i've installed 11.2.0. With that version the problem is not reproducible.

and i've also checked out the MR and it is fixing the problem for me as well in a local test on 11.x.

Thanks for reporting as always!

Think next step would be to address the phpstan issue and add test coverage.

Added the remaining tasks section and that the approach needs to be agreed upon.

I was not able to reproduce this issue against 11.3.2 or 11.x. Steps taken:

• composer require drupal/devel_generate
• drush si standard -y
• drush en media_library devel_generate -y
• drush genmd --media-types=image
• drush uli and log in
• Add an image media field to the Article content type
• Configure pager on media library view to full
• Add an article
• Press Add media to open the media library
• Navigate to page 2 or later
• Observe media library contains media elements

Screenshot:

@jurgenhaas thanks for the updated reproduction steps. I was able to see the same issue you did. I've updated the Steps to reproduce in the IS.

Doing a git bisect, I found #3122526: Pager links inside a modal do not open in the modal is the culprit. I confirmed that when testing against mainand reverting that issue's changes to core/lib/Drupal/Core/Pager/PagerPreprocess.php, the the pager for media library opened from CKEditor works correctly again.

Haven't investigated further to see whether the fix in the MR here is the best way forward.

Thanks for digging into this btw!

Following up from #13, in the specific case of the media library being opened in a modal from CKEditor this issue is this:

• Drupal\Core\Pager\PagerPreprocess::preprocessPager() is adding the 'use-ajax' class to all pager links, if the pager is being rendered in a modal
• The media_library view uses AJAX by default
• In ajax.js, Drupal.behaviors.AJAX calls Drupal.ajax.bindAjaxLinks, which AJAX-ifies all the use-ajax links in the document
• In ajax_view.js, Drupal.views.ajaxView eventually calls Drupal.views.ajaxView.prototype.attachPagerLinkAjax on all the pager links in the view and AJAX-ifies those links, and when doing so, adds data about the view to be sent in the request when the pager link is clicked
• Drupal.behaviors.AJAX runs before Drupal.views.ajaxView, so the AJAX click handler from Drupal.ajax.bindAjaxLinks runs instead of the handler from Drupal.views.ajaxView.prototype.attachPagerLinkAjax, so the request does not include the data associating the pager with the view, and so the node form is displayed in the modal instead of the media library view. (It also seems to have a side effect of removing the CKEditor toolbar from the editor as well.)

This can be verified by commenting out the 'class' => ['use-ajax'], in this stanza of Drupal\Core\Pager\PagerPreprocess::preprocessPager():

    if ($this->requestStack->getCurrentRequest()?->get(MainContentViewSubscriber::WRAPPER_FORMAT) === 'drupal_modal') {
      $link_attributes = [
        'class' => ['use-ajax'],
        'data-dialog-type' => 'modal',
        'data-accepts' => 'application/json',
      ];
    }

If that class is not applied to the pager links, the media library pager works correctly in the CKEditor modal.

I'm not sure what the best way is to address this specifically. Maybe some property like "#disable_modal_ajax_links" can be used in the preprocess to prevent use-ajax class from being added in modals, and the the render array returned from Drupal\views\Plugin\views\pager\Full::render() could set that to TRUE.

Setting the route to <none> might also be fine, but if the behavior ends up as expected, there are still two AJAX click handlers attached to every pager link.

Separately, the fix for #3122526: Pager links inside a modal do not open in the modal might have a separate bug in that the link attributes aren't applied to the "Last" pager link. Not sure whether that should be addressed here or in a new issue.

Added MediaLibraryWithPagerTest, which proves the issue described in #15. Provided a code suggestion involving an additional property, but I have some doubts about it.

Provided a code suggestion involving an additional property, but I have some doubts about it.

@alorenc Thank you for your great work on this! I also have doubts, but there didn't seem to be another way to detect that a pager is a view pager and that Views will handle making them AJAX links.

I added some MR comments, but as I was reviewing, it occurred to me that a View that is not configured to use AJAX and is put in a modal will have use-ajax links that will probably not load the view correctly.

One way forward is maybe this:

• Start with @jurgenhaas original approach by changing the route_name logic (Need to confirm that existing tests pass)
• Change the selector in ajax_view.js:
  

    Drupal.views.ajaxView.prototype.attachPagerAjax = function () {
      this.$view
        .find(
          '.js-pager__items a, th.views-field a, .attachment .views-summary a',
        )
        .each(this.attachPagerLinkAjax.bind(this));
    };
  

  to '.js-pager__items a:not(.use-ajax), th.views-field a, .attachment .views-summary a',

• Include the FJ MediaLibraryWithPagerTest in MR 14654. That's a very useful test

Anyone else have thoughts or suggestions?

Separately, the fix for #3122526: Pager links inside a modal do not open in the modal might have a separate bug in that the link attributes aren't applied to the "Last" pager link. Not sure whether that should be addressed here or in a new issue.

Stubbed #3572047: "Last" pager links inside a modal do not open in the modal for this.

Thanks for working on this! There are still unresolved comments in the MR, so moving back to NW for these.

Just here to concur with #25—this resolves the issue for us with ckeditor Media Library modals on 11.3.8. Thanks!