Problem/Motivation

Since symfony/validator 7.4: Support for passing the choices as the first argument to Symfony\Component\Validator\Constraints\Choice is deprecated.

Steps to reproduce

Proposed resolution

Call the Choice constructor with the choices named argument instead.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3555535

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

godotislate’s picture

godotislate
he/him
commented

Some of the work in MR 12291 for #3522497: Passing an $options array to constraint constructors is deprecated, use named arguments instead may be relevant.

longwave opened merge request !13700

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
godotislate’s picture

godotislate
he/him
commented
Status: Needs review » Reviewed & tested by the community

lgtm.

Will be good to get this in so I can rebase while working on #3555534: Since symfony/validator 7.4: Support for evaluating options in the base Constraint class is deprecated. Initialize properties in the constructor instead..

catch made their first commit to this issue’s fork.

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 1abec239 on 11.x 
    task: #3555535 Since symfony/validator 7.4: Support for passing the...

catch closed merge request !13700

  • catch committed 7a4689ae on 11.3.x 
    task: #3555535 Since symfony/validator 7.4: Support for passing the...
catch’s picture

catch
he/him
Primary language English
commented
Status: Fixed » Needs work

This broke HEAD, reverting.

catch reopened merge request !13700

  • catch committed d38a7ab3 on 11.3.x 
    Revert "task: #3555535 Since symfony/validator 7.4: Support for passing...

  • catch committed e0d8c3ec on 11.x 
    Revert "task: #3555535 Since symfony/validator 7.4: Support for passing...
godotislate’s picture

godotislate
he/him
commented
Status: Needs work » Needs review

There was a schema with a Choice constraint added upstream before this was committed, and MR is updated to fix. Tests are passing now.

  • catch committed e586ddcd on 11.3.x 
    task: #3555535 Since symfony/validator 7.4: Support for passing the...

  • catch committed f124b9e8 on 11.x 
    task: #3555535 Since symfony/validator 7.4: Support for passing the...
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Fixed

Trying again. Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !13700

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.