"Leave preview" points to undefined instead of node's edit page

This here is a follow up of that other issue.

Re-uploading the patch from #3308432-42: The link on the Image tag is redirecting to an undefined page from the node preview screen that fixes this issue. Credit needs to be given to @keshavv.

Hmmm, okay, just noticed now that #10 is just reverting what was done in #3308432: The link on the Image tag is redirecting to an undefined page from the node preview screen, so I guess this can't be the fix. Looks like we have to check both. Like this maybe:

let href = event.currentTarget.href;
if (href === undefined) {
  href = event.target.href;
}
window.top.location.href = href;

Fixes need to land in 11.x first as the development branch. Also fixes should be in MRs vs patches.

As a bug will also need test coverage too.

Thanks!

MRs is nice yeah, got created already. But as long as GitLab doesn't offer a way to get static, non-changing patches, we still need that patch here.

FYI you had it right the first time. MR has to go to 11.x first. Then depending when it lands committer decides to backport to relevant branches.

Would have needed a rebase first.

I had the issue on Drupal 11.2.4.
After applying the patch, I confirm that the problem is fixed.

Adding patch to Drupal 11.3.3

I started to attempt to add test coverage for this, but I think issue summary steps to reproduce are inaccurate. At least for me with Gin & Navigation, if I click 'Content' (or any Navigation link) since they are outside the preview area, the JS the triggers the Leave Preview process. Reproducing that in the tests, its successful even without the JS change, whereas in my site, the JS change is needed.

So functionality-wise RTBC +1 from me BUT still needs work as this test coverage passes even without the change as is.

Hopefully at least the test coverage gets someone going once issue summary is updated with clearer steps.

We ran into this issue as well, in our case the detected href was not correct because the event target was an img tag inside an a tag:

<a href="/">
    <img src="/themes/custom/something/assets/logo.svg">
</a>

event.target and event.currentTarget always pointed to the img tag. What we ended up doing was getting the href from this before the dialog is built.