Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
Splitting off migrate discovery from #3265945: Deprecate plugins using annotations and plugin types not supporting attributes as there are many annotation plugins in migrate.
Might make sense to postpone this to D12 so we can do it after migrate_drupal is removed instead of marking dozens of test as legacy.
Proposed resolution
Remaining tasks
User interface changes
no
API changes
no
Data model changes
no
Release notes snippet
no
Comments
Comment #2
catchIt looks like the current plan is to deprecate the Drupal 6/7 source plugins in #3507572: Deprecate migrate_drupal source plugins, this will probably result in a lot of the same tests being marked legacy, so we can possibly postpone this on that issue once @legacy is added to tests there?
Comment #3
godotislateAnother option would be to re-convert
migrate_drupalmigrate source plugins to attributes and set thesource_moduleproperty for them all in ahook_migrate_source_info_alterimplementation inmigrate_drupal. Effort probably would not be that high because all the plugin class changes could be brought back from an earlier commit, so it would just be purging the source_module property from them and writing the giant alter hook.Comment #4
berdirI think I like #3 because it's forward compatible. If someone is going to need migrate_drupal in D13, this needs to be done anyway.
Comment #5
catchmigrate_drupal is going to be deprecated with no replacement for removal in Drupal 12 rather than moved to contrib. This is on the basis that sites can migrate to Drupal 11 which will be supported until 2028, years after Drupal 6 and 7 went EOL. This doesn't preclude someone extracting the code from Drupal 11 to a contrib module anyway but it won't be done as part of the deprecation process.
Comment #6
berdirNoted, then I think we either wait on the tests to all be marked as deprecated in #3507572: Deprecate migrate_drupal source plugins or for D12 when it's gone.
This is just for runtime deprecations in tests. Doesn't stop anyone from writing a general purpose phpstan/upgrade_status detection for classes in plugin namespaces with annotations and no attributes that would also work on migrate plugins.