Problem/Motivation

34 hooks in various update_test_* modules currently have no return types.

Steps to reproduce

$ grep 'Function update_test_.* has no return type specified' core/.phpstan-baseline.php | wc -l
34

Proposed resolution

Add return types to those hooks.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3490638

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tstoeckler created an issue. See original summary.

tstoeckler opened merge request !10394

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Using the grep provided all instances seem updated

  • quietone committed f5cdfde1 on 11.1.x 
    Issue #3490638 by tstoeckler, smustgrave: Add return types to...

  • quietone committed 0cd8c5c2 on 11.x 
    Issue #3490638 by tstoeckler, smustgrave: Add return types to...
quietone’s picture

quietone commented
Version: 11.x-dev » 11.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to 11.x and cherry-picked to 11.1.x

Thanks!

quietone closed merge request !10394

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

Awesome, thanks for the quick turnaround!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.