Problem/Motivation

The test resizes the window but does not wait for events to completed.

Steps to reproduce

https://git.drupalcode.org/project/drupal/-/jobs/2215768

Proposed resolution

Add wait

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3463569

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !8912

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Can this be backported to 10.3.x to aid with backporting the W3C change?

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks good and let's backport to 10.3 yeah.

nod_ closed merge request !8912

  • nod_ committed 243fc5ca on 10.3.x 
    Issue #3463569 by alexpott, catch: ToolbarStoredStateTest needs wait...

  • nod_ committed ee43e75b on 10.4.x 
    Issue #3463569 by alexpott, catch: ToolbarStoredStateTest needs wait...

  • nod_ committed 27194eb0 on 11.0.x 
    Issue #3463569 by alexpott, catch: ToolbarStoredStateTest needs wait...

  • nod_ committed 3dc29858 on 11.x 
    Issue #3463569 by alexpott, catch: ToolbarStoredStateTest needs wait...
nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 3dc298586a to 11.x and 27194eb024 to 11.0.x and ee43e75bb6 to 10.4.x and 243fc5ca9e to 10.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Wow, epic find!

(Too bad we didn't have Functional JS test infra back in 2012/2013, when we built this. We could've anticipated it then. Although … we wouldn't have had the necessary experience yet to write robust tests of this kind — it took us years to get to that point.)