Problem/Motivation

UserPasswordResetTest uses a data provider, which because it's a functional test, means it installs Drupal twice more than it needs to. We can just use a foreach instead.

Before:

 ../vendor/bin/phpunit modules/user/tests/src/Functional/UserPasswordResetTest.php 
PHPUnit 10.5.26 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.8
Configuration: /var/www/html/core/phpunit.xml

	............                                                      12 / 12 (100%)

Time: 00:34.405, Memory: 6.00 MB

After:

 ../vendor/bin/phpunit modules/user/tests/src/Functional/UserPasswordResetTest.php 
PHPUnit 10.5.26 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.8
Configuration: /var/www/html/core/phpunit.xml

..........                                                        10 / 10 (100%)

Time: 00:28.516, Memory: 6.00 MB

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3462561

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

catch created an issue. See original summary.

catch’s picture

Status: Active » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Seems straight forward. Appears most changes were lines just shifting

nicxvan’s picture

Issue summary: View changes

  • nod_ committed 387e4e94 on 10.3.x
    Issue #3462561 by catch, smustgrave: Stop using a data provider in...
nod_’s picture

Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed a6f5d7d3ae to 11.x and 775c7267e9 to 11.0.x and b8de1821d5 to 10.4.x and 387e4e94b3 to 10.3.x. Thanks!

  • nod_ committed b8de1821 on 10.4.x
    Issue #3462561 by catch, smustgrave: Stop using a data provider in...

  • nod_ committed 775c7267 on 11.0.x
    Issue #3462561 by catch, smustgrave: Stop using a data provider in...

  • nod_ committed a6f5d7d3 on 11.x
    Issue #3462561 by catch, smustgrave: Stop using a data provider in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.