Spin-off from #3456244: Normalize the incoming path with urldecode directly in RouteProvider, I think we can make the caching more efficient.
Before:
| route:[language]=en:[query_parameters]=:/abcde | a:3:{s:4:"path";s:6:"/abcde";s:5:"query";a:0:{}s:6:"routes";O:41:"Symfony\Component\Routing\RouteCollection":4:{s:49:" Symfony\Component\Routing\RouteCollection routes";a:0:{}s:50:" Symfony\Component\Routing\RouteCollection aliases";a:0:{}s:52:" Symfony\Component\Routing\RouteCollection resources";a:0:{}s:53:" Symfony\Component\Routing\RouteCollection priorities";a:0:{}}} |
After:
| route:[language]=en:[query_parameters]=:/abcdef | a:3:{s:4:"path";s:7:"/abcdef";s:5:"query";a:0:{}s:6:"routes";b:0;}
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !8795
Comments
Comment #3
catchMR does two things:
1. When generating the cache ID, runs the same logic as the decode inbound path processor. That processor should be merged into the router, all it does by trying to decouple it is create inconsistencies. See #3456244: Normalize the incoming path with urldecode directly in RouteProvider for more.
2. When no routes are found, instead of caching a serialized empty route collection, caches FALSE instead. Given 404s are unbounded, while this is a relatively small saving, it's potentially multiplied by a lot of cache items.
Comment #4
andypostComment #5
catchMoved the URL normalization stuff into #3456244: Normalize the incoming path with urldecode directly in RouteProvider.
Comment #6
catchComment #7
smustgrave commentedearly returns make sense.
Not for this issue but would be neat to eventually have a performance test around caching if possible?
Comment #8
catchI did think about test coverage here but all we could really do is assert the contents of the cache entry when no routes are found rather than a performance test, which feels a bit too much like repeating what the code does.
Comment #11
nod_some phpcs issue
Comment #12
catchSorry, sloppiness.
Comment #16
nod_Committed and pushed da5f6215a9 to 11.x and 41ac5c1446 to 10.4.x. Thanks!