Problem/Motivation

The deprecation note:

 * @deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. Use
 *   \Drupal\user\UserValidator::validateName() instead.

is pointing to the non-existing \Drupal\user\UserValidator class.

Proposed resolution

Correct this to point to \Drupal\user\UserNameValidator instead.

Issue fork drupal-3459240

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jurgenhaas created an issue. See original summary.

jurgenhaas opened merge request !8671

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Active » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

Thanks, though the @trigger_error line below also needs updating to match.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Needs work » Needs review

Ouch, missed that. Thanks for the heads-up.

b_sharpe’s picture

b_sharpe commented
Status: Needs review » Needs work

Missing one in the test.

b_sharpe’s picture

b_sharpe commented
Status: Needs work » Needs review

Added missing test case

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: Deprecation not for user_validate_name ponts to an invalid replacement » Deprecation message for user_validate_name points to an invalid replacement
Status: Needs review » Reviewed & tested by the community

Thanks, this all looks correct to me now.

quietone’s picture

quietone commented

Doing RTBC triage and this is fine, ready to go. I am in review mode otherwise I would commit.

catch closed merge request !8671

  • catch committed 3f397e20 on 10.3.x 
    Issue #3459240 by jurgenhaas, b_sharpe, longwave, quietone: Deprecation...

  • catch committed 84546deb on 10.4.x 
    Issue #3459240 by jurgenhaas, b_sharpe, longwave, quietone: Deprecation...

  • catch committed 89e13d46 on 11.0.x 
    Issue #3459240 by jurgenhaas, b_sharpe, longwave, quietone: Deprecation...

  • catch committed 717b02a8 on 11.x 
    Issue #3459240 by jurgenhaas, b_sharpe, longwave, quietone: Deprecation...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked back through to 10.3.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.