Problem/Motivation

While working on #3393400: Implement Nightwatch tests for Navigation module it was necessary to create a workaround to enable Navigation module for Nightwatch tests.
Source root of this issue is that confirmation form id is different when there are experimental modules involved.

Test ends up throwing an exception like this:

  1)  ✖ NightwatchAssertError
   Timed out while waiting for element <#system-modules-confirm-form> to be present for 10000 milliseconds. - expected "found" but got: "not found" (10133ms)

Steps to reproduce

  • Create a Nightwatch test
  • Try to enable an experimental module using drupalInstallModule('navigation')
  • Confirm Error

Proposed resolution

Give support for bopth experimental and non-experimental selectors in drupalInstallModule()

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3455058

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

plopesc created an issue. See original summary.

plopesc opened merge request !8429

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Active » Needs review

Created basic MR to address this bug.

I was not able to find tests to cover this Nightwatch command, so I assume that MR is ok as it is. There are no regression and experimental modules support could be tested once the #3393400: Implement Nightwatch tests for Navigation module is merged.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems straightforward and non disruptive

  • nod_ committed 630dd1bd on 10.4.x 
    Issue #3455058 by plopesc, smustgrave: drupalInstallModule nightwatch...

  • nod_ committed 5a3a9165 on 11.0.x 
    Issue #3455058 by plopesc, smustgrave: drupalInstallModule nightwatch...

  • nod_ committed f355d928 on 11.x 
    Issue #3455058 by plopesc, smustgrave: drupalInstallModule nightwatch...

nod_ closed merge request !8429

nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 10.4.x-dev
Status: Reviewed & tested by the community » Fixed

Testing test commands in nightwatch is not something we're currently doing, so I'm happy with it.

Committed and pushed f355d928bf to 11.x and 5a3a916565 to 11.0.x and 630dd1bda0 to 10.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.