Problem/Motivation
#3439580: Make drupal.tableheader only use CSS for sticky table headers allowed the sticky header in table feature to be done with CSS only instead of JavaScript.
In https://git.drupalcode.org/project/drupal/-/blob/10.3.x/core/modules/vie...
$form['sticky'] = [
'#type' => 'checkbox',
'#title' => $this->t('Enable Drupal style "sticky" table headers (JavaScript)'),
'#default_value' => !empty($this->options['sticky']),
'#description' => $this->t('(Sticky header effects will not be active for preview below, only on live output.)'),
];
The checkbox title still mentions JavaScript.
Proposed resolution
The (JavaScript) in the checkbox title should be removed.
Remaining tasks
- do the change in MR
- review
- approval
User interface changes
A checkbox title will be updated.
Before: Enable Drupal style "sticky" table headers (JavaScript)
After: Enable Drupal style "sticky" table headers
API changes
None
Data model changes
None
Release notes snippet
Needed?
Comments
Comment #3
grimreaperComment #4
bramdriesenCame here from the parent issue. Changes looks good and tests are green. So I guess we can RTBC this!
Comment #5
bramdriesenNot sure if it needs to be added to the change record as well, as this isn't really changing any code beside titles/translations.
Comment #10
nod_Committed and pushed cdb29302e4 to 11.x and 6ae84f94e1 to 11.0.x and 8ed474db0c to 10.4.x and ba0a3ad06b to 10.3.x. Thanks!