Problem/Motivation

#3439580: Make drupal.tableheader only use CSS for sticky table headers allowed the sticky header in table feature to be done with CSS only instead of JavaScript.

In https://git.drupalcode.org/project/drupal/-/blob/10.3.x/core/modules/vie...

    $form['sticky'] = [
      '#type' => 'checkbox',
      '#title' => $this->t('Enable Drupal style "sticky" table headers (JavaScript)'),
      '#default_value' => !empty($this->options['sticky']),
      '#description' => $this->t('(Sticky header effects will not be active for preview below, only on live output.)'),
    ];

The checkbox title still mentions JavaScript.

Proposed resolution

The (JavaScript) in the checkbox title should be removed.

Remaining tasks

- do the change in MR
- review
- approval

User interface changes

A checkbox title will be updated.

Before: Enable Drupal style "sticky" table headers (JavaScript)

After: Enable Drupal style "sticky" table headers

API changes

None

Data model changes

None

Release notes snippet

Needed?

Issue fork drupal-3451738

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

Assigned: grimreaper » Unassigned
Status: Active » Needs review
bramdriesen’s picture

Status: Needs review » Reviewed & tested by the community

Came here from the parent issue. Changes looks good and tests are green. So I guess we can RTBC this!

bramdriesen’s picture

Not sure if it needs to be added to the change record as well, as this isn't really changing any code beside titles/translations.

  • nod_ committed ba0a3ad0 on 10.3.x
    Issue #3451738 by Grimreaper, BramDriesen: Remove JavaScript from Views...

  • nod_ committed 8ed474db on 10.4.x
    Issue #3451738 by Grimreaper, BramDriesen: Remove JavaScript from Views...

  • nod_ committed 6ae84f94 on 11.0.x
    Issue #3451738 by Grimreaper, BramDriesen: Remove JavaScript from Views...

  • nod_ committed cdb29302 on 11.x
    Issue #3451738 by Grimreaper, BramDriesen: Remove JavaScript from Views...
nod_’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +String change

Committed and pushed cdb29302e4 to 11.x and 6ae84f94e1 to 11.0.x and 8ed474db0c to 10.4.x and ba0a3ad06b to 10.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.